Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[search] removing extra bottom line #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2018

Conversation

s-pace
Copy link
Contributor

@s-pace s-pace commented Nov 7, 2018

Enhance #934

@dbader
Copy link
Member

dbader commented Nov 7, 2018

@s-pace Cool—can you change the placeholder on the search input to "Search the Guide"? Thx

#934 (comment)

@s-pace
Copy link
Contributor Author

s-pace commented Nov 7, 2018

Sure!

@dbader
Copy link
Member

dbader commented Nov 7, 2018

Perfect, thanks @s-pace :-) LGTM!

@dbader dbader merged commit 4a4dae7 into realpython:master Nov 7, 2018
@s-pace
Copy link
Contributor Author

s-pace commented Nov 8, 2018

Feel free to provide us any feedback. We would love to enhance our tool

@dbader
Copy link
Member

dbader commented Nov 8, 2018

@s-pace Cheers I'll keep it in mind! Love how quick the search is!

@s-pace s-pace deleted the www/fix/search_script_position branch April 17, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants