Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BetterPhpDocParser] Add ArrayItemNode to improve value transfer in annotation curly lists#2786

Merged
TomasVotruba merged 4 commits into
mainfrom
tv-string-object-items
Aug 20, 2022
Merged

[BetterPhpDocParser] Add ArrayItemNode to improve value transfer in annotation curly lists#2786
TomasVotruba merged 4 commits into
mainfrom
tv-string-object-items

Conversation

@TomasVotruba

@TomasVotruba TomasVotruba commented Aug 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch 2 times, most recently from 0439f2e to 4d230d3 Compare August 18, 2022 23:46
@TomasVotruba TomasVotruba changed the title tv string object items [WIP] [BetterPhpDocParser] Add ListItemNode to improve value transfer in annotation curly lists Aug 18, 2022
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch 8 times, most recently from 10318ae to 8253b7a Compare August 19, 2022 07:55
@TomasVotruba TomasVotruba mentioned this pull request Aug 19, 2022
Merged
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch 6 times, most recently from 3acae33 to 490c584 Compare August 20, 2022 15:25
@TomasVotruba TomasVotruba changed the title [WIP] [BetterPhpDocParser] Add ListItemNode to improve value transfer in annotation curly lists [WIP] [BetterPhpDocParser] Add ArrayItemNode to improve value transfer in annotation curly lists Aug 20, 2022
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch 4 times, most recently from 0bb3bde to 9549c6d Compare August 20, 2022 16:03
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch from 1329ff2 to b4ed5e6 Compare August 20, 2022 16:55
@TomasVotruba TomasVotruba changed the title [WIP] [BetterPhpDocParser] Add ArrayItemNode to improve value transfer in annotation curly lists [BetterPhpDocParser] Add ArrayItemNode to improve value transfer in annotation curly lists Aug 20, 2022
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch from dc5ca49 to c85ba67 Compare August 20, 2022 17:01
@TomasVotruba TomasVotruba mentioned this pull request Aug 20, 2022
Merged
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch 2 times, most recently from 367347d to 2bc5532 Compare August 20, 2022 17:25
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch from 14b19fb to 2bc5532 Compare August 20, 2022 17:26
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch from e38c46a to 51c144e Compare August 20, 2022 17:55
@TomasVotruba TomasVotruba mentioned this pull request Aug 20, 2022
Merged
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch 5 times, most recently from ca9f623 to 863eb33 Compare August 20, 2022 19:10
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch 8 times, most recently from e7af5d9 to 4e44275 Compare August 20, 2022 20:35
@TomasVotruba TomasVotruba force-pushed the tv-string-object-items branch from 4e44275 to 7fb9237 Compare August 20, 2022 20:40
@TomasVotruba

TomasVotruba commented Aug 20, 2022

Copy link
Copy Markdown
Member Author

CI passed 🎉 🎉 🎉

Let's ship it to test edge-cases :) this will make changing particular items much easier, with no quote/double quote/single quote magic 👍

@TomasVotruba TomasVotruba merged commit a33b200 into main Aug 20, 2022
@TomasVotruba TomasVotruba deleted the tv-string-object-items branch August 20, 2022 20:45
@samsonasik samsonasik mentioned this pull request Aug 20, 2022
Merged
@samsonasik

samsonasik commented Aug 20, 2022

Copy link
Copy Markdown
Member

@TomasVotruba I create new PR to preserve key unordered not from 0 integer rollback #2811

@TomasVotruba TomasVotruba mentioned this pull request Aug 21, 2022
Merged
@samsonasik samsonasik mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomasVotruba @samsonasik