[Php80] Rollback preserve int key defined not start from 0 Fixture on AnnotationToAttributeRector#2811
Merged
Conversation
997f2b5 to
a07b46e
Compare
Member
Author
|
rebased. |
Member
Author
|
It seems cause error: There was 1 failure:
1) Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\AnnotationToAttributeRectorTest::test with data set #14 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/Doctrine/preserve_int_key_defined.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
use Doctrine\ORM\Mapping as ORM;
-#[ORM\DiscriminatorMap([1 => 'CostDetailEntity'])]
+#[ORM\DiscriminatorMap(['1' => 'CostDetailEntity'])] |
Member
Author
|
@TomasVotruba the the change seems make it single quoted to make CI green now e0f9d16 , compared to real integer on original PR : |
Member
Author
|
Fixed 🎉 by update
|
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
TomasVotruba
approved these changes
Aug 20, 2022
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Int key "1" unordered key defined is valid in Doctrine\ORM\Mapping\DiscriminatorMap per issue
that was resolved at:
It changed to string in latest PR:
This PR rollback the transformation fixture for integer unorder key fixture to avoid regression.