Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Php80] Validate ArrayItem on CurlyListNodeAnnotationToAttributeMapper#2814

Merged
TomasVotruba merged 4 commits into
mainfrom
validate-array-item-node
Aug 21, 2022
Merged

[Php80] Validate ArrayItem on CurlyListNodeAnnotationToAttributeMapper#2814
TomasVotruba merged 4 commits into
mainfrom
validate-array-item-node

Conversation

@samsonasik

@samsonasik samsonasik commented Aug 21, 2022

Copy link
Copy Markdown
Member

Continue of #2811:

  • ensure that mapped values are ArrayItem to catch possible bug early.
  • always cast to (int) first before compare key value for numeric data as key is quoted.
  • no need to include ArrayItem inside ArrayItem, just add it into the array

@samsonasik samsonasik changed the title [Php80] Validate ArrayItemNode and ArrayItem on CurlyListNodeAnnotationToAttributeMapper [Php80] Validate ArrayItem on CurlyListNodeAnnotationToAttributeMapper Aug 21, 2022
@samsonasik

Copy link
Copy Markdown
Member Author

All checks have passed πŸŽ‰ @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit ffa1221 into main Aug 21, 2022
@TomasVotruba TomasVotruba deleted the validate-array-item-node branch August 21, 2022 14:25
@TomasVotruba

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants