[php 8.1] skip nullable property without null default in NewInInitializerRector #7546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
commented
Oct 23, 2025
| ) { | ||
| $this->logger = $logger ?? new NullLogger(); | ||
| } | ||
| } |
There was a problem hiding this comment.
@samsonasik This is one of cases that would always throw error if upgraded.
Here, without null default, the null is always passed from outside to trigger:
new SkipIfNoDefaultNull(null); // only way to create NullLogger
samsonasik
reviewed
Oct 23, 2025
4caf859 to
b91e37a
Compare
… from outside to trigger
7618b53 to
e0a05cb
Compare
auto-merge was automatically disabled
October 23, 2025 09:14
Head branch was modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.