Checks if getState() returns plain object or Immutable type #81
Conversation
|
Hi @florisvink Thank you for raising this concern. We, at Dixie, have been considering to use ImmutableJS for the store for a while too. So we find it very relevant. What we have decided though, is that redux-json-api is not supposed to be a do-it-all lib, which knows about various ways of handling a Redux store. So to implement knowledge in redux-json-api about ImmutableJS, we don't find to be the best solution. Our thought so far have been to, a some point, create a new extension, redux-json-api-immutablejs (or whatever) which would extend the core logic from this lib, but provide it through an ImmutableJS interface. The same thing could then be done for other mutation-handling libs, so this library is agnostic about in what way your application handles state. Any thoughts on this? Would you be interested in working on this prototype? |
|
Closed due to inactivity. |
|
Hi @egeriis For example import { combineReducers } from 'redux';
import { createApiReducer } from 'redux-json-api';
import { storeMutator } from 'redux-json-api-immutable'
const api = createApiReducer(storeMutator);
export default combineReducers({
api
});where storeMutator is of course quite a simple function :) |
As a possible fix for #80 I wrote this PR. If this is something you want to include into the module I can write some tests as well.
Text from the original issue see below:
Internally the module uses ImmutalbleJS for setting the api-states, but the api-reducer cannot be combined with existing reducers when the initialState of the store is Immutable:
For example:
This code results in:
TypeError: Cannot read property 'endpoint' of undefined: getState().api.endpoint;The code looks like:
I think (in case the root-state is Immutable) this should be something like: