The color contrast isn't there anymore, as a colorblind individual, its now really close to the green now.

hi @busches and @arnaudvalle, what about a blue color since it is very helpful to know when a change is requested on a PR. Currently there is no difference in visual when review is requested or change is requested. Here is a screenshot with a blue(#3f29b9)

Blue looks like a link; perhaps purple? Or a dark pink, which is still red-ish but less aggressive https://primer.style/css/support/color-system

Otherwise we can just go with dark yellow for icons (like a WIP) and gray/black for text like regular comments

Alright - here are a few variants taken from your comments:

purple 500:

pink 600:

yellow 700 + black text:

My preference goes to "yellow 700 + black text".

Red is for when something is broken or denied. Green for successes and approvals. The orange color (yellow 700) is already known for pending and waiting status, which this is.

My preference goes to "yellow 700 + black text".

I agree. Purple and pink seem to come a bit out of nowhere (I don't remember seeing them elsewhere in the interface) and I don't think they're really associated (at least in my mind as a regular user) to a specific message like yellow/warning.

Plus it just feels/flows better with the other items in that area from a UI point of view I reckon.

Yeah I think yellow works.

Perhaps save the color as a variable in content.css

I made the change to yellow icon + dark text as discussed.

I'm not convinced anymore. The moment I opened my first "changes requested PR" I thought that the CI was still running because that's the color that GitHub uses in that case.

Right, I see. Any other suggestion? How about something grey? Similar to when you have merge conflicts:

Interesting. GitHub is using gray to show an action needs to be taken, so I wouldn’t mind it for Requested Changes too

Would look like this:

If we go with grey, I'd suggest we also make the main surrounding border grey as well as the main branch icon indicator, like they do on the Draft PRs?

(oops sorry about the comment in the wrong PR, I posted my message in the one I was testing on because it had requested changes... :()

Yeah, gray looks good to me.

🎉

Not a fan of this, think it should be reverted. It was mostly voted down to begin with and it feels a bit confusing and superfluous