Codestin Search App

hardikmodha · 2020-01-05T17:01:06Z

Using the latest commit available on the repo root and the total number of commits to fetch the oldest commit.

Test

fregante

Looks great!

Just a thought for now, but perhaps it would be nice to also link to that first commit since we have the information on the same page and every piece in the summary is also a link.

source/features/repo-age.tsx

yakov116 · 2020-01-05T17:13:33Z

@fregante should we fall back to the old way if there are no commits?

fregante · 2020-01-05T17:19:40Z

should we fall back to the old way if there are no commits?

I don't think anybody cares about repos without commits 😄

At most we can prevent the error by using if count === 0, return false

hardikmodha · 2020-01-05T17:23:15Z

I think just returning makes sense, saves us an unnecessary request.

This reverts commit d3d326b.

hardikmodha · 2020-01-05T18:09:51Z

Just a thought for now, but perhaps it would be nice to also link to that first commit since we have the information on the same page and every piece in the summary is also a link.

Makes sense. Each and every item is a link in summary we can do that.

hardikmodha · 2020-01-05T18:43:15Z

@fregante I have incorporated the changes to point to the oldest commit in the repo-age but this introduces a change that will break for existing cached values. I'm now expecting cached values to be a valid JSON string but they are date strings.
Do we want to handle it for the existing values?

yakov116 · 2020-01-05T18:46:46Z

@hardikmodha looks great. One thing with this change there is a noticeable jump on every load.

hardikmodha · 2020-01-05T18:51:23Z

@yakov116 Yes, I noticed that as well. I'm working on adding some sort of loader icon as we discussed.

fregante · 2020-01-05T18:53:39Z

No need to get fancy with loaders. The user timezone feature just uses a static Guessing timezone… placeholder

fregante · 2020-01-05T18:55:51Z

Do we want to handle it for the existing values?

I think it’s nicer to handle that now and drop the code later rather than add extra text to our clear key name 😁

source/features/repo-age.tsx

yakov116 · 2020-01-05T19:55:49Z

❌ repo-age
content.js:3474 RangeError: Invalid time value
    at repo_age_init (content.js:9396)
    at async features_run (content.js:3469)

hardikmodha · 2020-01-05T20:01:47Z

@yakov116 I was not handling the existing cached values previously. Now, I am. Can you check again?

yakov116 · 2020-01-05T20:02:36Z

@hardikmodha nope try
https://github.com/sindresorhus/got
Its crashing on title: First commit dated ${dateFormatter.format(date)}

hardikmodha · 2020-01-05T20:04:46Z

@yakov116 It's working for me. Are you sure on the latest commit?

yakov116 · 2020-01-05T20:05:24Z

Yup

yakov116 · 2020-01-06T03:37:01Z

@hardikmodha I also noticed it will fail on any link that the path has tree in it (open a file from this pr and go to the main page)

source/features/repo-age.tsx

fregante · 2020-01-06T04:56:31Z

If this is starting to look like a lot of moving parts, you can also split the PR into 2 pieces:

use updated data source (the initial intent of the PR)
add "loading..."
or even a 3rd piece: add link (which means changing the data format) (this was why I marked the suggestion as "Just a thought for now")

1. Do not wait for DOM for fetching commit details. 2. Remove unnecessary function 3. Edit content of repo-age item on summary row

…entReady

source/features/repo-age.tsx

fregante · 2020-01-12T18:16:26Z

source/features/repo-age.tsx

+		return false;
+	}
+
+	if (commitsCount === 1) {


I think repos with a single commit are rare enough that we can drop this condition.

Then, What do we display for 1 commit repo?

Without this condition, it will just continue like it would with more commits, to fetchDom etc.

But the request would not return anything, the page returned by fetchDom would be empty and we won't find any commits there....

Ouch. Didn’t think it would be. I guess it can stay then.

source/features/repo-age.tsx

fregante · 2020-01-28T10:26:47Z

Hardik can you split this into multiple PRs as suggested before? #2667 (comment)

The first 2 PRs should be pretty straightforward and can be merged quickly. The 3rd apparently is taking a while to discuss

hardikmodha added 2 commits December 29, 2019 14:43

Fix tags dropdown on releases page. Closes refined-github#2658

d3d326b

Merge branch 'master' of github.com:sindresorhus/refined-github

8048601

fregante added the enhancement label Jan 5, 2020

Use first commit to get the repo age. Closes refined-github#2660

b486593

hardikmodha force-pushed the use_first_commit_for_repo_age branch from a52da6a to b486593 Compare January 5, 2020 17:04

fregante requested changes Jan 5, 2020

View reviewed changes

hardikmodha added 2 commits January 5, 2020 23:22

Suggested review changes

d2a24ba

Revert "Fix tags dropdown on releases page" from this PR

e06ffd5

This reverts commit d3d326b.

hardikmodha force-pushed the use_first_commit_for_repo_age branch from 98c5a62 to e06ffd5 Compare January 5, 2020 17:55

hardikmodha marked this pull request as ready for review January 5, 2020 17:59

hardikmodha requested a review from fregante January 5, 2020 17:59

Add link to the oldest commit for repo-age

0d9eacc

fregante reviewed Jan 5, 2020

View reviewed changes

source/features/repo-age.tsx Outdated Show resolved Hide resolved

source/features/repo-age.tsx Show resolved Hide resolved

source/features/repo-age.tsx Outdated Show resolved Hide resolved

source/features/repo-age.tsx Outdated Show resolved Hide resolved

Backward compatible and UX improvement

e631a12

hardikmodha force-pushed the use_first_commit_for_repo_age branch from 7a61131 to e631a12 Compare January 5, 2020 19:59

Lint fix

29e27aa

fregante mentioned this pull request Jan 6, 2020

Additional "is expired" check in cache.function fregante/webext-storage-cache#9

Closed

fregante requested changes Jan 6, 2020

View reviewed changes

source/features/repo-age.tsx Outdated Show resolved Hide resolved

source/features/repo-age.tsx Outdated Show resolved Hide resolved

source/features/repo-age.tsx Outdated Show resolved Hide resolved

source/features/repo-age.tsx Outdated Show resolved Hide resolved

hardikmodha added 9 commits January 10, 2020 20:44

Merge branch 'master' of github.com:sindresorhus/refined-github

ab08fac

Merge branch 'master' of github.com:sindresorhus/refined-github

de22d9c

Merge branch 'master' into use_first_commit_for_repo_age

9c3839d

Add isExpired check

5e1b980

Improvements

c1e1473

1. Do not wait for DOM for fetching commit details. 2. Remove unnecessary function 3. Edit content of repo-age item on summary row

Handle case when there is only one commit

928e764

Try to fix issue when .commit-tease-sha was not found even after elem…

e94e8d7

…entReady

Fix URL

61f0dc5

Lint fix

6a399ba

hardikmodha force-pushed the use_first_commit_for_repo_age branch from 40f0850 to 6a399ba Compare January 12, 2020 14:57

hardikmodha requested a review from fregante January 12, 2020 15:00

hardikmodha commented Jan 12, 2020

View reviewed changes

source/features/repo-age.tsx Outdated Show resolved Hide resolved

Use getRepoURL

1cbcee1

fregante requested changes Jan 12, 2020

View reviewed changes

fregante mentioned this pull request Jan 14, 2020

Fix isExpiring function types fregante/webext-storage-cache#13

Closed

hardikmodha added 2 commits January 18, 2020 20:42

Fix types for isExpired function

0f36199

Set stopOnDomReady for commit hash and use the same

7b1bf84

hardikmodha requested a review from fregante January 18, 2020 16:34

tooomm mentioned this pull request Jan 20, 2020

Link to review from the overview at the end of a PR #2712

Closed

fregante reviewed Jan 20, 2020

View reviewed changes

source/features/repo-age.tsx Show resolved Hide resolved

arnaudvalle mentioned this pull request Jan 22, 2020

Add friendlier-requested-changes feature #2611

Merged

fregante mentioned this pull request Jan 27, 2020

Accept undefined in .set and .function (skips the cache) fregante/webext-storage-cache#14

Merged

fregante closed this Jan 28, 2020

hardikmodha mentioned this pull request Feb 15, 2020

Determine repo-age with its first commit #2783

Merged

kidonng mentioned this pull request Mar 12, 2020

On commits page, next to Newer and Older buttons, add buttons called Newest and Oldest #2882

Closed

Uh oh!

Conversation

hardikmodha commented Jan 5, 2020

Test

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yakov116 commented Jan 5, 2020

Uh oh!

fregante commented Jan 5, 2020

Uh oh!

hardikmodha commented Jan 5, 2020

Uh oh!

hardikmodha commented Jan 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardikmodha commented Jan 5, 2020

Uh oh!

yakov116 commented Jan 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardikmodha commented Jan 5, 2020

Uh oh!

fregante commented Jan 5, 2020

Uh oh!

fregante commented Jan 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yakov116 commented Jan 5, 2020

Uh oh!

hardikmodha commented Jan 5, 2020

Uh oh!

yakov116 commented Jan 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hardikmodha commented Jan 5, 2020

Uh oh!

yakov116 commented Jan 5, 2020

Uh oh!

yakov116 commented Jan 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fregante Jan 12, 2020

Choose a reason for hiding this comment

Uh oh!

hardikmodha Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

fregante Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hardikmodha Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

fregante Jan 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Jan 28, 2020

Uh oh!

Reviewers

hardikmodha commented Jan 5, 2020 •

edited

Loading

yakov116 commented Jan 5, 2020 •

edited

Loading

yakov116 commented Jan 5, 2020 •

edited

Loading

fregante commented Jan 6, 2020 •

edited

Loading

fregante Jan 14, 2020 •

edited

Loading