Use a consistent border color - #3657
Merged
Merged
Conversation
- move to CSS variable - normalize to color `#e1e4e8` - use 1px border width for pinned issues
Reset pinned issues border to 2px after read the discussion 馃槃 #3491
Reset border width to 2px since is not the purpose of this PR.
Member
|
Can you please provide before and after screenshots |
Author
Done! It's a subtle change 馃槄 |
Member
|
I have to double check but I think that works! Thank you! |
fregante
approved these changes
Oct 16, 2020
Member
|
cc @silverwind heads up for updated CSS colors |
Contributor
|
Should probably be automatically handled by our tooling. BTW GitHub now has CSS vars of their own, you should switch to them (for example |
Merged
Contributor
|
Automation picked it up just fine: StylishThemes/GitHub-Dark@badb3c9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#e1e4e8Thanks for contributing! 馃崉
LINKED ISSUES:
No issue
TEST URLS:
https://github.com/ (dashboard)
SCREENSHOT:
The border after "All activity" was darker.