Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make clean-pinned-issues more visible - #3659

Closed
ocarreterom wants to merge 1 commit into
refined-github:masterfrom
ocarreterom:update-clean-pinned-issues
Closed

Make clean-pinned-issues more visible#3659
ocarreterom wants to merge 1 commit into
refined-github:masterfrom
ocarreterom:update-clean-pinned-issues

Conversation

@ocarreterom

Copy link
Copy Markdown

Update pinned issues style to be more accurate with the GitHub theme. 💅

Thanks for contributing! 🍄

  1. LINKED ISSUES:
    Continue the discussion Make clean-pinned-issues slightly more visible #3491

  2. TEST URLS:
    https://github.com/sindresorhus/refined-github/issues

  3. SCREENSHOT:

Before After
Captura de pantalla 2020-10-16 a las 0 41 20 Captura de pantalla 2020-10-16 a las 0 43 26

Update pinned issues style to be more accurate with the GitHub theme.
@busches

busches commented Oct 16, 2020

Copy link
Copy Markdown
Member

They look selected now, not a fan.

@fregante

Copy link
Copy Markdown
Member

I don’t think I’ve seen that style anywhere else; if you have an example of GitHub using it we can discuss whether we should match it.

@ocarreterom

Copy link
Copy Markdown
Author

For example GitHub use this style for:

  1. Emphasize some section in a view like notification actions banner and files list header.

Captura de pantalla 2020-10-16 a las 17 28 22

Captura de pantalla 2020-10-16 a las 17 29 03

  1. To highlight items on a list like your own comments on issues and PRs and notifications on hover.

Captura de pantalla 2020-10-16 a las 17 28 43

Captura de pantalla 2020-10-16 a las 17 27 26

There are some guidelines about blue boxes in Primer docs https://primer.style/css/components/box#blue-box-theme


The selected/active style should be more like this:
Captura de pantalla 2020-10-16 a las 18 21 52


Another suggestion 🤷‍♂️

Before After
96194030-c6f66d80-0f49-11eb-91d2-8e8a7353e856 Captura de pantalla 2020-10-16 a las 18 09 17

In my opinion, the 2px width seems more like a glitch than a feature 😶

@notlmn

notlmn commented Oct 16, 2020

Copy link
Copy Markdown
Contributor

Maybe this can go along with #3657, using the same colors? Do those colors work here?

@fregante

Copy link
Copy Markdown
Member

Maybe this can go along with #3657

That's a gray border, this is blue as per https://primer.style/css/components/box#blue-box-theme

@fregante fregante changed the title Update clean-pinned-issues style Make clean-pinned-issues more visible Oct 17, 2020
@fregante

Copy link
Copy Markdown
Member

@sindresorhus thoughts on the style? Worth the change?

@sindresorhus

Copy link
Copy Markdown
Member

I think they look too "heavy" now. Maybe we could reduce the background color opacity to half?

background-color: rgb(241 248 255 / 0.5);

Screen Shot 2020-11-20 at 10 22 48

@fregante

Copy link
Copy Markdown
Member

I don't think this change is necessary after all. Thanks for opening the discussion though

@fregante fregante closed this Dec 15, 2020
@ocarreterom
ocarreterom deleted the update-clean-pinned-issues branch December 15, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants