Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Drop recently-pushed-branches-enhancements feature - #3753

Merged
fregante merged 1 commit into
masterfrom
bye-recently-pushed-branches-enhancements
Nov 23, 2020
Merged

Drop recently-pushed-branches-enhancements feature#3753
fregante merged 1 commit into
masterfrom
bye-recently-pushed-branches-enhancements

Conversation

@fregante

@fregante fregante commented Nov 22, 2020

Copy link
Copy Markdown
Member

Re: #3748

Fixes #3518
Closes #3748

@yakov116

Copy link
Copy Markdown
Member

Can we give it another chance? I'll wait for Sindre but I really liked the feature.

@sindresorhus

sindresorhus commented Nov 22, 2020

Copy link
Copy Markdown
Member

Too bad. I use this feature all the time. Only saves some seconds though, so I understand it might not be worth the continuous effort.

@fregante

Copy link
Copy Markdown
Member Author

Can we give it another chance

Only if you push a PR before this one is merged. ⏲

@fregante

fregante commented Nov 22, 2020

Copy link
Copy Markdown
Member Author

so I understand it might not be worth the continuous effort.

The issue is that not only is it troublesome, it breaks badly: #3333 #2044 #3748

I think its main reason to exist (to avoid content jump) could be brought back in a saner manner:

  1. hide the banner by default
  2. detect its presence and add a "fresh branches available" notification button icon somewhere. The style of a custom 16x16 button is much more manageable

Clicking the button would unhide the regular bar in its regular position. This adds a click but doesn't affect the style.

Alternative solutions welcome.

@yakov116

Copy link
Copy Markdown
Member

@fregante if you are expecting that quickly, don't think I will be able to do that. I can try to fix the css classes.

@yakov116

yakov116 commented Nov 23, 2020

Copy link
Copy Markdown
Member

45 minutes of trying... I give up. I though they just changed the classes. looks like they changed some layout.

You win.... I lose. 😢

@fregante
fregante merged commit 5acb00e into master Nov 23, 2020
@fregante
fregante deleted the bye-recently-pushed-branches-enhancements branch November 23, 2020 06:26
@fregante

fregante commented Nov 23, 2020

Copy link
Copy Markdown
Member Author

Let's try to live without this feature for a while and open a new specific issue to something you'd like to solve.

For historical purposes, the original request issues:

@yakov116 yakov116 added the meta Related to Refined GitHub itself label Mar 4, 2021
@yakov116 yakov116 added feature dropped and removed meta Related to Refined GitHub itself feature dropped labels Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Drop recently-pushed-branches-enhancements recently-pushed-branches-enhancements may cause duplicate banners

3 participants