Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add clean-repo-sidebar feature - #3783

Merged
fregante merged 23 commits into
refined-github:masterfrom
cheap-glitch:add-clean-repo-sidebar
Dec 27, 2020
Merged

Add clean-repo-sidebar feature#3783
fregante merged 23 commits into
refined-github:masterfrom
cheap-glitch:add-clean-repo-sidebar

Conversation

@cheap-glitch

@cheap-glitch cheap-glitch commented Dec 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for contributing! 🍄

  1. LINKED ISSUES: Closes hide-empty-meta stopped working #3668

  2. TEST URLS:

  1. SCREENSHOTS:
clean-repo-sidebar

clean-repo-sidebar

hide-zero-packages

hide-zero-packages

@yakov116

yakov116 commented Dec 1, 2020

Copy link
Copy Markdown
Member

This needs a migration

@fregante

fregante commented Dec 1, 2020

Copy link
Copy Markdown
Member

Ideally, yes. In practice, eh 🤷‍♂️

That was not really a feature that made sense being disabled.

@fregante

fregante commented Dec 1, 2020

Copy link
Copy Markdown
Member

Preview screenshot needed both in the first comment and in the readme (eventually)

@fregante

fregante commented Dec 1, 2020

Copy link
Copy Markdown
Member

should we also hide the "No packages published" text? (or even the whole "Packages" section?)

We have a feature that hides packages; does it hide it? Why not? Did we discuss this in that feature or it was just forgotten?

@yakov116

yakov116 commented Dec 1, 2020

Copy link
Copy Markdown
Member

Ideally, yes. In practice, eh 🤷‍♂️

That was not really a feature that made sense being disabled.

So true not even sure why I suggested it...

@cheap-glitch

This comment has been minimized.

Sign in to view
yakov116
yakov116 reviewed Dec 2, 2020
View reviewed changes
Comment thread readme.md Outdated
@cheap-glitch

cheap-glitch commented Dec 4, 2020

Copy link
Copy Markdown
Contributor Author

Since hide-zero-packages only targets tabs and the "Packages" tab in the repo root has been replaced by the "Packages" section in the sidebar, I moved the part of hide-zero-packages that dealt with repo roots to clean-repo-sidebar.

@cheap-glitch cheap-glitch mentioned this pull request Dec 4, 2020
Closed
cheap-glitch
cheap-glitch commented Dec 4, 2020
View reviewed changes
Comment thread source/features/clean-repo-sidebar.tsx Outdated
@fregante fregante mentioned this pull request Dec 7, 2020
Closed
FloEdelmann
FloEdelmann reviewed Dec 7, 2020
View reviewed changes
Comment thread source/features/clean-repo-sidebar.tsx Outdated
fregante
fregante requested changes Dec 15, 2020
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature should be renamed to clean-conversation-sidebar

https://github.com/sindresorhus/refined-github/blob/master/source/features/clean-sidebar.tsx

Comment thread source/features/clean-repo-sidebar.tsx Outdated
Comment thread source/features/clean-repo-sidebar.tsx Outdated
fregante
fregante reviewed Dec 18, 2020
View reviewed changes
Comment thread readme.md Outdated
fregante
fregante reviewed Dec 18, 2020
View reviewed changes
Comment thread source/features/clean-repo-sidebar.tsx Outdated
yakov116
yakov116 requested changes Dec 20, 2020
View reviewed changes
Comment thread source/refined-github.ts
Comment thread source/refined-github.ts
@yakov116

This comment has been minimized.

Sign in to view
@cheap-glitch

This comment has been minimized.

Sign in to view
@yakov116

This comment has been minimized.

Sign in to view
@yakov116
yakov116 self-requested a review December 20, 2020 18:08
@yakov116

yakov116 commented Dec 20, 2020

Copy link
Copy Markdown
Member

Oh I see what's happening were good here!

@yakov116
yakov116 removed their request for review December 20, 2020 18:11
yakov116
yakov116 reviewed Dec 20, 2020
View reviewed changes
Comment thread source/features/clean-repo-sidebar.css Outdated
yakov116
yakov116 reviewed Dec 21, 2020
View reviewed changes
Comment thread source/features/clean-repo-sidebar.tsx
yakov116
yakov116 reviewed Dec 21, 2020
View reviewed changes
Comment thread source/features/clean-repo-sidebar.tsx Outdated
yakov116
yakov116 reviewed Dec 22, 2020
View reviewed changes
Comment thread source/features/clean-repo-sidebar.tsx Outdated
@cheap-glitch cheap-glitch mentioned this pull request Dec 24, 2020
Merged
@fregante
fregante merged commit 30640fa into refined-github:master Dec 27, 2020
@fregante

fregante commented Dec 27, 2020

Copy link
Copy Markdown
Member

🥳

@cheap-glitch
cheap-glitch deleted the add-clean-repo-sidebar branch December 27, 2020 09:04
@yakov116 yakov116 mentioned this pull request Dec 27, 2020
Closed
@fregante fregante mentioned this pull request Feb 14, 2021
Closed
This was referenced Feb 21, 2021
Closed
Merged
yakov116 added a commit that referenced this pull request Jun 16, 2021
@yakov116
Remove selector left over from #3783
0a7fba9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloEdelmann FloEdelmann FloEdelmann left review comments
@yakov116 yakov116 yakov116 requested changes
@fregante fregante Awaiting requested review from fregante

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hide-empty-meta stopped working

4 participants

@cheap-glitch @yakov116 @fregante @FloEdelmann