Conversation
fregante
commented
Jan 20, 2021
| select('.d-block.mb-2[href^="/contact"]')!.after( | ||
| <a href={String(actionURL)} className="d-block mb-2"> | ||
| <SearchIcon width={14} className="text-gray-dark mr-2"/>Usage examples | ||
| <SearchIcon width={14} className={SearchIcon.defaultProps.className + ' text-gray-dark mr-2'}/>Usage examples |
Member
Author
There was a problem hiding this comment.
Ugly.
Also the types seem to be broken
- because
SearchIconis nowany- because
React.FCisanyin octicon’s types.
- because
Did vadimdemedes/dom-chef#62 break anything here or has it always been like this? We also have this In our globals.d.ts:
declare module 'react' {
const FC = (): JSX.Element => JSX.Element;
const React = {FC};
export default React;
}
Member
Author
There was a problem hiding this comment.
@TheRealSyler have you been using version 5 of dom-chef since your PR? Do you know whether this block needs to be dropped or included in dom-chef?
fregante
commented
Jan 20, 2021
| href={downloadUrl.href} | ||
| > | ||
| <DownloadIcon className="mr-1"/> | ||
| <DownloadIcon className={DownloadIcon.defaultProps.className + ' mr-1'}/> |
Member
Author
There was a problem hiding this comment.
Maybe it should just use
Suggested change
| <DownloadIcon className={DownloadIcon.defaultProps.className + ' mr-1'}/> | |
| <DownloadIcon className="octicon octicon-download mr-1"/> |
fregante
marked this pull request as ready for review
February 1, 2021 16:43
fregante
marked this pull request as draft
February 1, 2021 16:56
Member
Author
|
Closing because that PR is inactive |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows vadimdemedes/dom-chef#62 and vadimdemedes/dom-chef#75