Conversation
Member
|
It鈥檚 best to fix the logic by splitting the init function in 2 |
set-default-repositories-type-to-sources selector
fregante
reviewed
Jan 25, 2021
Co-authored-by: Federico <[email protected]>
set-default-repositories-type-to-sources selectorset-default-repositories-type-to-sources
yakov116
reviewed
Jan 28, 2021
fregante
approved these changes
Jan 28, 2021
set-default-repositories-type-to-sourcesset-default-repositories-type-to-sources
set-default-repositories-type-to-sourcesset-default-repositories-type-to-sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! 馃崉
LINKED ISSUES: Fixes
set-default-repositories-type-to-sources: undefined is not an object (evaluating 'link.search')聽#3908TEST URLS: Update to next dom-chef聽#3904 > Go to "Commits" tab > Hover on your avatar
SCREENSHOT: -
Changing the selector fixes this, but maybe it's better to check the return value of
select()instead of applying the modification twice?