Codestin Search App

yakov116 · 2021-07-20T12:21:03Z

Test URLs

https://github.com/nodejs/node/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Aconfirmed-bug
https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22bug%22
https://github.com/MithrilJS/mithril.js/issues?q=is%3Aissue+is%3Aopen+label%3A%22Type%3A+Bug%22+sort%3Aupdated-desc
https://github.com/yakov116/TestR/issues?q=is%3Aissue+is%3Aopen+label%3A%22%3Abug%3A+bug%22+sort%3Aupdated-desc

Screenshot

fregante · 2021-07-20T15:03:51Z

yakov116 · 2021-07-20T15:04:54Z

OMG!! WOW How did I make such a mistake 🤦

fregante · 2021-07-20T15:45:52Z

This feature keeps getting longer and longer…. 😅

yakov116 · 2021-07-20T15:46:13Z

Buggy code 😏

yakov116 · 2021-07-26T12:56:26Z

I'll look into it when I have time. But yet maybe you can revert the change where you're having trouble

@fregante ready.

Right now the only thing that is broken is the .add it needs "

yakov116 · 2021-07-27T12:00:07Z

 	}

+	static escapeValue(value: string): string {
+		return /\s|^:/.test(value) ? `"${value}"` : value;


Changed is since GitHub will add quotes if it starts with a : or if it contains a space you can test it https://github.com/yakov116/TestR/labels

Doesn't look accurate: https://github.com/fregante/sandbox/issues?q=is%3Aopen+sort%3Aupdated-desc+label%3A%3Aa%3A

I think it only happens for spaces, but there might be other characters as well. It might be worth creating new labels to test this out. You can do so in a test repo from the issue sidebar

I did you want more tests?

I mean manual tests on GitHub.com to determine what characters triggers the quotes. From what I see, currently this should be:

Suggested change

return /\s|^:/.test(value) ? `"${value}"` : value;

return value.includes(' ') ? `"${value}"` : value;

But what about

https://github.com/yakov116/TestR/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A%22t+%3A%2B1%3A%22 ??

maybe if it has an emoji?

Great idea lets include!

https://github.com/markdown-it/markdown-it-emoji/blob/339abf72f84a02e66fe9a4d682a7217d1f660e6a/dist/markdown-it-emoji.js#L9-L1848

… that label has a space

Also emojis are fine: https://github.com/fregante/sandbox/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3A😃m

fregante · 2021-08-02T20:37:09Z

Uhhhh this could have been useful 2 weeks ago 😂 https://github.blog/changelog/2021-08-02-search-issues-by-label-using-logical-or/

Might be worth updating the feature? The current situation is still better for the user though since:

only one label appears in the query
we can support any label with regex

So we're good without it anyway 😁

yakov116 · 2021-08-03T00:59:21Z

Yup I think the way it is now is good. But if we see a need we know we have other options.

mcornella · 2021-09-23T16:15:09Z

This doesn't seem to support uppercase characters in the label for me. Shouldn't the regex end with /i?

yakov116 · 2021-09-23T17:09:39Z

This doesn't seem to support uppercase characters in the label for me. Shouldn't the regex end with /i?

Can you give a real url?

mcornella · 2021-09-23T17:16:07Z

This one from the original post doesn't seem to work for me:

But this repo works:

yakov116 · 2021-09-23T17:43:26Z

Thanks
Can you open a new issue?

mcornella · 2021-09-23T18:16:40Z

I've opened #4811. I tried the /i in supportedLabels and it looks like it solves it.

yakov116 · 2021-09-23T18:41:03Z

You can send a PR

yakov116 added 2 commits July 20, 2021 08:15

First atempt

a215e18

Use label API

e971077

yakov116 added the change request label Jul 20, 2021

yakov116 changed the title ~~First atempt~~ Include other bug labels in bugs-tab Jul 20, 2021

Fix quote issue

7818a77

fregante reviewed Jul 20, 2021

View reviewed changes

Comment thread source/features/bugs-tab.tsx Outdated

yakov116 commented Jul 20, 2021

View reviewed changes

Comment thread source/features/bugs-tab.tsx Outdated

fregante force-pushed the main branch 2 times, most recently from 461391d to da213cf Compare July 20, 2021 15:33

fregante reviewed Jul 20, 2021

View reviewed changes

Comment thread source/features/bugs-tab.tsx Outdated

yakov116 closed this Jul 20, 2021

yakov116 reopened this Jul 20, 2021

yakov116 added 5 commits July 20, 2021 21:10

Start cleanup

065c365

/2

3538e3a

Lint

c1db624

/2

8c3da66

/3

55c3c68

yakov116 marked this pull request as ready for review July 21, 2021 03:13

yakov116 requested a review from fregante July 21, 2021 03:14

fregante reviewed Jul 21, 2021

View reviewed changes

yakov116 added 2 commits July 21, 2021 07:57

DRY

3caaa0b

Cleanup

bec54b9

fregante reviewed Jul 21, 2021

View reviewed changes

Comment thread source/features/bugs-tab.tsx Outdated

Part 1

6847e00

yakov116 commented Jul 21, 2021

View reviewed changes

Comment thread source/features/bugs-tab.tsx Outdated

Make include work without the quotes

48fbe82

My code did nothing so remove it

7491b1b

fregante added 5 commits July 26, 2021 23:14

Duplicate regex

ebce9f9

Fix weird indentation, nonsensical variable names, wrong AnyObject type

c1db74a

Lint

00c51ff

Clean

da2c439

Fix label search logic

064643c

fregante requested changes Jul 26, 2021

View reviewed changes

Comment thread source/github-helpers/search-query.ts Outdated

fregante and others added 3 commits July 26, 2021 23:39

Fix last change

5570e0a

No 160-char long lines

176c619

Add escapeValue

a7fbc03

fregante reviewed Jul 27, 2021

View reviewed changes

Comment thread source/features/bugs-tab.tsx Outdated

Fix escapeValue regex

3cfd6e9

yakov116 commented Jul 27, 2021

View reviewed changes

yakov116 and others added 3 commits July 27, 2021 08:01

Remove the ? find will not crash

eec73ca

Remove TODO

e08ef56

Update source/github-helpers/search-query.ts

d2323cb

fregante merged commit f09a145 into main Jul 28, 2021

fregante deleted the bug-me branch July 28, 2021 06:27

omBratteng mentioned this pull request Aug 10, 2021

Support kind:bug label in bugs-tab #4650

Merged

fregante mentioned this pull request Sep 24, 2021

bugs-tab doesn't take into account bug labels with uppercase letters #4811

Closed

1 task

yakov116 mentioned this pull request Jul 6, 2022

Allow more bug labels #5784

Closed

	return /\s\|^:/.test(value) ? `"${value}"` : value;
	return value.includes(' ') ? `"${value}"` : value;

Uh oh!

Uh oh!

Conversation

yakov116 commented Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test URLs

Screenshot

Uh oh!

fregante commented Jul 20, 2021

Uh oh!

yakov116 commented Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Jul 20, 2021

Uh oh!

yakov116 commented Jul 20, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yakov116 commented Jul 26, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yakov116 Jul 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fregante commented Aug 2, 2021

Uh oh!

yakov116 commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcornella commented Sep 23, 2021

Uh oh!

yakov116 commented Sep 23, 2021

Uh oh!

mcornella commented Sep 23, 2021

Uh oh!

yakov116 commented Sep 23, 2021

Uh oh!

mcornella commented Sep 23, 2021

Uh oh!

yakov116 commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

yakov116 commented Jul 20, 2021 •

edited

Loading

yakov116 commented Jul 20, 2021 •

edited

Loading

yakov116 Jul 27, 2021 •

edited

Loading

yakov116 commented Aug 3, 2021 •

edited

Loading