Fix GitHub color variables - #4982
Conversation
cheap-glitch
left a comment
There was a problem hiding this comment.
Should we add a TODO comment somewhere reminding us to remove all the obsolete classes and variables, in maybe 6 months?
This comment has been minimized.
This comment has been minimized.
| transform: translate(50%, 50%); | ||
| min-width: 380px; /* Avoids a width change on the last step which causes the YES button to be where NO was */ | ||
| box-shadow: var(--color-toast-shadow); | ||
| box-shadow: var(--color-shadow-large, var(--color-toast-shadow)); |
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
| [data-color-mode="light"] .rgh-conflict-marker svg { | ||
| color: #ccc; | ||
| } | ||
|
|
||
| [data-color-mode="dark"] .rgh-conflict-marker svg { | ||
| color: var(--color-fg-muted); | ||
| } |
There was a problem hiding this comment.
GitHub dropped color-icon/text-tertiary and advises to replace it with color-fg-muted in the migration guide.
While this works well in dark mode, it's too strong in light mode, so I opted to manually check for the current mode and keep the old color in the light one.
Everywhere else I used color-fg-subtle which is still darker than tertiary was, but is closer to it than fg-muted.
|
Finally! I always feel strange about the colors when I thought the fix has already been merged (probably because of the previous PR). |
Fixes #4855
Follow-up of #4970
Test URLs
conflict-marker: https://github.com/fregante/github-sandbox/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+conflictrefined-github.css:striked textstriked text in codeScreenshot
Before
After
