Conversation
Member
Author
|
There's a comment left for #4982 that would require a lot of related changes, it'd be great to see that cleanup done separately |
fregante
marked this pull request as ready for review
May 21, 2022 08:27
fregante
commented
May 21, 2022
| "allowWarningComments": false | ||
| }], | ||
| "@typescript-eslint/naming-convention": "off", | ||
| "@typescript-eslint/no-redundant-type-constituents": "off", |
Member
Author
There was a problem hiding this comment.
Due to the wrong Deinit type introduced by #5422
| "__filebasename" | ||
| ], | ||
| "rules": { | ||
| "jsx-quotes": "error", |
Member
Author
There was a problem hiding this comment.
Too much noise on an existing codebase
| import features from '.'; | ||
| import looseParseInt from '../helpers/loose-parse-int'; | ||
|
|
||
| // TODO [2022-05-01]: Drop GHE code and merge function back in init |
Member
Author
There was a problem hiding this comment.
No merge needed; init is large enough
|
|
||
| type AnyObject = Record<string, any>; | ||
| // TODO: Fix this type, there's no such `delegate` global type | ||
| type Deinit = delegate.Subscription | Observer | MutationObserver | ResizeObserver | IntersectionObserver | VoidFunction; |
Member
Author
There was a problem hiding this comment.
delegate.Subscription and therefore Deinit are any due to #5422 @cheap-glitch
FloEdelmann
reviewed
May 21, 2022
Co-authored-by: Flo Edelmann <[email protected]>
Member
Author
|
All PRs merged, 20 bug issues open. I haven鈥檛 seen that in a while New release coming in 10-15 hours. If I forget, please someone do it, let鈥檚 release 22.5.22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃ゴ