Meta: Safer text node targeting - #6076
Merged
Merged
Conversation
FloEdelmann
reviewed
Oct 12, 2022
Co-authored-by: Flo Edelmann <[email protected]>
fregante
commented
Nov 4, 2022
| tagIcon.classList.add('mr-2'); | ||
| // Remove whitespace node | ||
| tagIcon.nextSibling!.remove(); | ||
| } |
Member
Author
There was a problem hiding this comment.
| append: createBannerLink, | ||
| }); | ||
| function initArchivedRepoBanner(signal: AbortSignal): void { | ||
| observe('[itemprop="name"] ~ .Label--attention', addLinkToBanner, {signal}); |
Member
Author
There was a problem hiding this comment.
Found a way to make this feature instant
| // eslint-disable-next-line @typescript-eslint/ban-types -- Nodes may be exactly `null` | ||
| export const assertNodeContent = <N extends Text | ChildNode>(node: N | null, expectation: RegExp | string): N => { | ||
| if (!node || !(node instanceof Text)) { | ||
| console.warn('TypeError', node); |
Member
Author
There was a problem hiding this comment.
I wish there was a way to attach data to errors and have the browser actually display it. error.PROP is basically inaccessible from the console, let alone visible
fregante
marked this pull request as ready for review
November 4, 2022 05:26
Member
Author
|
Everything tested. Merging 🚀 |
This was referenced Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested.This should avoid future issues where the text nodes change position and we silently remove the wrong element.