Improve clean-repo-sidebar - #3974

Thanks for all your the prs!

• Fix "conflict" with repo-age

Would running repo-age after clean-repo-sidebar help?

As we discussed in the previous PR, we can never hide the whole about section because we have repo-age. If people disable it, tough luck.

Also since you’re moving the entire release link instead of just hiding parts of it, I’d suggest testing repos that have tags but not releases. I think they also appear there, just differently.

Love the screenshots, thanks!

It works for repos with tags instead of releases, but the vertical alignment is a bit wonky:

Is it worth fixing this? I don't remember seeing a lot of repos with this config.

The spacing on repo-age seems excessive too, especially compared to the url just above it

The spacing on repo-age seems excessive too

It matches the one of the license link, which is absent here. So fixing this would also mean changing the spacing of the license link too.

Let's just update the tag’s spacing if it exists. Probably something like select(tag icon)?.classList.add(whatever margin class the others use)

The icon spacing incongruence also applies to releases:

And this link is still here:

Also, I used the classes instead of rgh-clean-releases because they're exact and defined by GitHub, this way we don't have to keep magic numbers in our CSS.

The icon spacing incongruence also applies to releases

Actually in this case the spacing is correct, but the text of the first two links has some whitespace at the beginning. If we remove it, the alignment becomes correct:

And this link is still here

Should also we hide the "Learn more about GitHub sponsors" link?

Should also we hide the "Learn more about GitHub sponsors" link?

I thought about it but the link is unique and it’s not an obvious feature.

https://github.com/broofa/npmgraph

This is misaligned as well, I'm not sure if there's a clean way other than finding that and removing .mt-3. Ideally this should be handled automatically via CSS (e.g. add negative margin on top of the whole about section). I'm not sure if there are negative classes, like mt--3, worth a look in their stylesheet.

If you prefer not fixing all of these issues, we can merge this as is and I'll open a new issue.

the text of the first two links has some whitespace at the beginning. If we remove it

Ugh 😰 I think we don't have a choice. The release widget uses flex so we can't add a space there, it's just ignored. I guess the alternative is to:

• remove the space from repo-age in our JSX
• have repo-age remove the license space, so they're consistent between themselves, regardless of this feature.

remove the space from repo-age in our JSX
have repo-age remove the license space, so they're consistent between themselves, regardless of this feature.

Should this be in a separate PR?

Should this be in a separate PR?

Up to you:

If you prefer not fixing all of these issues, we can merge this as is and I'll open a new issue.

Those fixes are only necessary due to this feature anyway, so it's ok if they're part of the same PR

Should also we hide the "Learn more about GitHub sponsors" link?

I thought about it but the link is unique

It's also in the little modal box that pops up when you click the "Sponsor" button in the repo header.

Unfortunately if there are no releases there's a blank space:

Source: https://github.com/justinfrankel/licecap

Without RG:

I think this is because we only hide the Release title via CSS but not the whole section?

Generally I think that the new CSS-only rules are a little brittle so we should probably just use some JS to ensure we're selecting the right elements and using the right logic.

As always, we can merge as is and open a new issue. Still up to you

All problems should be fixed now. I tested every link in Firefox & Chromium, with and without repo-age enabled.

In the end I had to rely on an ugly margin-top: -16px to fix the top alignment, because there's just too many different cases to fix with JS (especially when putting repo-age in the mix).

Should we also hide the "Learn more about GitHub sponsors" link?

I thought about it but the link is unique

It's also in the little modal box that pops up when you click the "Sponsor" button in the repo header.

@fregante can I get your definitive opinion on this before I redo the screenshots?

@fregante can I get your definitive opinion on this before I redo the screenshots?

Let's leave it as is for now

In the end I had to rely on an ugly margin-top: -16px to fix the top alignment

Yeah that's ok for now, better than having to cover every single situation

All problems should be fixed now. I tested every link in Firefox & Chromium, with and without repo-age enabled.

Thanks for being so thorough! It's a feature with many moving parts

I redo the screenshots?

I'd say they're fine. No need to be super-exact, we just need to show what the feature does approximately.