Thanks to visit codestin.com
Credit goes to github.com

Skip to content

closing-remarks - Exclude nightly tags and non-version tags - #7243

Merged
fregante merged 2 commits into
mainfrom
closing-nightlies
Feb 2, 2024
Merged

closing-remarks - Exclude nightly tags and non-version tags#7243
fregante merged 2 commits into
mainfrom
closing-nightlies

Conversation

@fregante

fregante commented Feb 2, 2024

Copy link
Copy Markdown
Member Author

cc @wookayin Note that some PR merge commits appear in the tags, other do not. This is not a bug of RGH.

See: neovim/neovim#25125

No tag because GitHub reports no tag on the merge commit: neovim/neovim@f5a09f1

Screenshot 10

@fregante
fregante merged commit d818aa3 into main Feb 2, 2024
@fregante
fregante deleted the closing-nightlies branch February 2, 2024 09:14
@wookayin

wookayin commented Feb 2, 2024

Copy link
Copy Markdown

Thank you very much for positively considering this! Yes, that specific commit isn't released yet so I think that'd be a correct behavior.

@fregante

fregante commented Feb 2, 2024

Copy link
Copy Markdown
Member Author

that specific commit isn't released yet

Are you sure? That commit is 4 months old and is on master.

@jmcarcell

Copy link
Copy Markdown

Can someone explain what is needed for the message "This pull request first appeared in 24.2.2" to appear? Does one need to make a release from Github? In some other repositories I don't see these messages even though there is certainly a tag that has them.

@fregante

fregante commented Apr 3, 2024

Copy link
Copy Markdown
Member Author

When you merge a PR, GitHub creates a commit. You can see the commit hash in the event immediately following the merge.

Refined GitHub asks GitHub if this commit appears in any tags.

If it doesn't work in some repos, it's probably because they create a tag from another branch (e.g. "git flow" method). Also it might just be a Refined GitHub cache issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

closing-remarks: options to exclude pre-release tags (feature request)

3 participants