Fix closing recordings/tables that are still being loaded showing up again #10963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
a4565ec to
7f69475
Compare
7f69475 to
761d088
Compare
Wumpf
approved these changes
Aug 22, 2025
Wumpf
approved these changes
Aug 22, 2025
|
Created a follow-up issue about request cancellation: #10967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug_asserttriggers when closing partially loaded recording #9848To reproduce the issue, open a large partition or throttle your network speed. As it's loading, close it in the recording panel. It actually stays there and continues downloading.
The fix is to drop the receiver as well.
I also noticed that dropping the receiver doesn't immediately cancel the download, the
GetChunkscontinues in the background according to the console network tab. We should probably look into making those requests fully cancel safe