Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use ViewerImportUrl for updating history, adds more unit tests #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 29, 2025
Merged

Use ViewerImportUrl for updating history, adds more unit tests #11034

merged 10 commits into from
Aug 29, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 28, 2025

Mostly a refactor that got split out of other ongoing work

  • integrate valid values of LogDataSource into ViewerImportUrl to avoid handling the same weird corner cases all the time
  • display_mode_to_content_url is now integrated/split into ViewerImportUrl via ViewerImportUrl::from_display_mode and ViewerImportUrl::sharable_url
    • sharable_url already handles appending the a web viewer base to it which will be relevant in the next PR

But also:

  • tons of new tests for these
  • fix some corner cases with the example/welcome page where it was possible to get into a state where we add an invalid server & show the welcome page
  • fix some formatting issue on intra recording urls

@Wumpf Wumpf added 🔨 testing testing and benchmarks 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ c081d60 https://rerun.io/viewer/pr/11034 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf added the do-not-merge Do not merge this PR label Aug 28, 2025
@Wumpf Wumpf mentioned this pull request Aug 28, 2025
Merged
@Wumpf Wumpf requested a review from abey79 August 28, 2025 16:45
abey79
abey79 approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward, LGTM.

@Wumpf @abey79
add whitespace
ae8da80 
Co-authored-by: Antoine Beyeler <[email protected]>
@Wumpf Wumpf merged commit e2d108d into main Aug 29, 2025
12 of 21 checks passed
@Wumpf Wumpf deleted the andreas/import-url-from-displaymode branch August 29, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality 🔨 testing testing and benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @abey79