Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 28, 2025

Related

What

The Copy Direct Link command previously only worked on the Web and would only copy the base url unless you looked at an http recording. Now it copies the URL based on the current display mode (just like what we put in the addressbar on web).

Thanks to the unified logic link logic you can use this for aribtrary navigation on both web & native now

link.based.nav.on.native.mp4

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself do-not-merge Do not merge this PR include in changelog labels Aug 28, 2025
Copy link

github-actions bot commented Aug 28, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
b227088 https://rerun.io/viewer/pr/11035 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf force-pushed the andreas/universal-link-copy-action branch 2 times, most recently from 4cad3c9 to 0eabea6 Compare August 28, 2025 16:14
@Wumpf Wumpf requested a review from abey79 August 28, 2025 16:45
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Base automatically changed from andreas/import-url-from-displaymode to main August 29, 2025 15:40
@Wumpf Wumpf force-pushed the andreas/universal-link-copy-action branch from 0eabea6 to 3dbfcb6 Compare August 29, 2025 15:51
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Aug 29, 2025
@Wumpf Wumpf merged commit b9ba856 into main Aug 29, 2025
39 of 40 checks passed
@Wumpf Wumpf deleted the andreas/universal-link-copy-action branch August 29, 2025 16:06
Wumpf added a commit that referenced this pull request Aug 29, 2025
### Related

* Part of #10866

### What

Web viewer URL bar reacts to this accordingly, [copy direct
link](#11035) will pick it up and
you can navigate to the resulting URL in all the places that take URLs
(like command line or command pallette or `url` parameter)



https://github.com/user-attachments/assets/f9843337-70bc-4708-9256-5395686c0534

(ignore errors & missing loads. Sandbox is having some issues as of
writing)

Also fixes an issue where navigation back to the server looked broken
because it didn't select it as well as general missing redraws.
@aedm aedm added exclude from changelog PRs with this won't show up in CHANGELOG.md and removed include in changelog labels Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants