Add guest option to org users #8216
Conversation
|
Thanks Cyrus! Some feedback: Proposed Changes:
|
Addressed the proposed changes. @ericokuma |
| <div class="mt-3"> | ||
| <div class="text-xs font-medium mb-1">Project access</div> | ||
| {#if $projectsQuery?.isLoading} | ||
| <div class="text-xs text-slate-500">Loading projects…</div> |
There was a problem hiding this comment.
We use a spinner everywhere in the app. Is there a design to use text instead? If not we should stick to using spinners.
| {#if $projectsQuery?.isLoading} | ||
| <div class="text-xs text-slate-500">Loading projects…</div> | ||
| {:else if $projectsQuery?.error} | ||
| <div class="text-xs text-red-500">Failed to load projects</div> |
There was a problem hiding this comment.
We should display the error as well. Perhaps the full page error triggers? Please test it once, you can manually throw error in the tanstack query methods.
| class="font-normal flex items-center overflow-hidden" | ||
| checked={selectedProjects.includes(p.name)} | ||
| on:click={() => { | ||
| const idx = selectedProjects.indexOf(p.name); |
There was a problem hiding this comment.
Move this somewhat complex handler out of markup.
|
|
||
| {#if failedInvites.length > 0} | ||
| <div class="text-sm text-red-500 py-2"> | ||
| {failedInvites.length === 1 |
There was a problem hiding this comment.
What is this supposed to say? xyz already failed to invite doesnt make sense to me.
| @@ -0,0 +1,297 @@ | |||
| <script lang="ts"> | |||
There was a problem hiding this comment.
Lets call this AddGuestsDialog to match the verb of the backend API
| ? 'bg-slate-200' | ||
| : 'hover:bg-slate-100'} px-2 py-1" | ||
| > | ||
| <span>{roleLabel(selectedRole)}</span> |
There was a problem hiding this comment.
Why not use ORG_ROLES_OPTIONS ? No need for roleLabel either.
This PR implements the feature to invite guest users with project access selection from org users. Closes https://linear.app/rilldata/issue/APP-229/force-project-access-selection-when-creating-guest-users-at-org-user
CleanShot.2025-10-31.at.17.59.46.mp4
Checklist: