Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This auto-generates two more files that contain the references to the Node constructors as well as the type constants. Especially the former is something that is easily forgotten when adding new nodes and can lead to strange bugs.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 7:08am

Copy link

github-actions bot commented Apr 30, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#auto-generate-node-index

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-89sl937gi-rollup-js.vercel.app/repl/?pr=5504

Copy link

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.157 ± 0.037 9.130 9.199 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.260 ± 0.015 9.245 9.274 1.01 ± 0.00

Internal benchmark

  • BUILD: 8154ms, 753 MB
    • initialize: 0ms, 26.1 MB
    • generate module graph: 3121ms, 575 MB
      • generate ast: 1499ms, 568 MB
    • sort and bind modules: 452ms, 617 MB
    • mark included statements: 4577ms, 753 MB
      • treeshaking pass 1: 1541ms, 718 MB
      • treeshaking pass 2: 740ms, 740 MB
      • treeshaking pass 3: 294ms, 741 MB
      • treeshaking pass 4: 271ms, 749 MB
      • treeshaking pass 5: 316ms, 752 MB
      • treeshaking pass 6: 266ms, 750 MB
      • treeshaking pass 7: 245ms, 755 MB
      • treeshaking pass 8: 238ms, 753 MB
      • treeshaking pass 9: 218ms, 750 MB
      • treeshaking pass 10: 220ms, 750 MB
      • treeshaking pass 11: 217ms, 753 MB
  • GENERATE: 878ms, 1.03 GB
    • initialize render: 0ms, 914 MB
    • generate chunks: 79ms, 926 MB
      • optimize chunks: 0ms, 919 MB
    • render chunks: 782ms, 1 GB
    • transform chunks: 17ms, 1.03 GB
    • generate bundle: 0ms, 1.03 GB

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (5e955a1) to head (69cb865).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5504   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         238      238           
  Lines        9540     9540           
  Branches     2437     2437           
=======================================
  Hits         9427     9427           
  Misses         48       48           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit f8f166c into master Apr 30, 2024
@lukastaegert lukastaegert deleted the auto-generate-node-index branch April 30, 2024 07:38
Copy link

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant