-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Auto generate node index #5504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto generate node index #5504
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#auto-generate-node-index Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5504 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 238 238
Lines 9540 9540
Branches 2437 2437
=======================================
Hits 9427 9427
Misses 48 48
Partials 65 65 ☔ View full report in Codecov by Sentry. |
This PR has been released as part of [email protected]. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This auto-generates two more files that contain the references to the Node constructors as well as the type constants. Especially the former is something that is easily forgotten when adding new nodes and can lead to strange bugs.