-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: watch mode add allowInputInsideOutputPath
option
#5966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: watch mode add allowInputInsideOutputPath
option
#5966
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5966 +/- ##
==========================================
+ Coverage 98.77% 98.78% +0.01%
==========================================
Files 270 270
Lines 8734 8733 -1
Branches 1509 1509
==========================================
Hits 8627 8627
Misses 73 73
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In this scenario, the watch will be triggered repeatedly until the test case times out. I am not sure how to write this test case. |
But isn't this exactly the reason why we forbid watching inputs? To avoid infinite loops? |
Yes. But in #5956 some users mentioned that our previous changes caused problems in some of their scenes. So should we add a parameter to allow the previous code logic to be maintained? |
test/cli/samples/watch/watch-output-contain-input-allowInputInsideOutputPath/rollup.config.mjs
Outdated
Show resolved
Hide resolved
I changed the test so that while the input is in the output directory, the generated output is not also the input. I think that is indeed a valid scenario and I would merge it thus. |
@lukastaegert Thank you for your review. 👍 |
This PR has been released as part of [email protected]. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
close #5956