Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

btea
Copy link
Contributor

@btea btea commented May 28, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

close #5956

Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 1:42pm

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (13b4669) to head (32fda4e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5966      +/-   ##
==========================================
+ Coverage   98.77%   98.78%   +0.01%     
==========================================
  Files         270      270              
  Lines        8734     8733       -1     
  Branches     1509     1509              
==========================================
  Hits         8627     8627              
  Misses         73       73              
+ Partials       34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@btea btea marked this pull request as ready for review May 29, 2025 23:12
@btea
Copy link
Contributor Author

btea commented May 29, 2025

In this scenario, the watch will be triggered repeatedly until the test case times out. I am not sure how to write this test case.

@lukastaegert
Copy link
Member

In this scenario, the watch will be triggered repeatedly until the test case times out. I am not sure how to write this test case.

But isn't this exactly the reason why we forbid watching inputs? To avoid infinite loops?

@btea
Copy link
Contributor Author

btea commented Jun 1, 2025

Yes. But in #5956 some users mentioned that our previous changes caused problems in some of their scenes. So should we add a parameter to allow the previous code logic to be maintained?

@lukastaegert
Copy link
Member

I changed the test so that while the input is in the output directory, the generated output is not also the input. I think that is indeed a valid scenario and I would merge it thus.

@lukastaegert lukastaegert enabled auto-merge June 6, 2025 13:42
@btea
Copy link
Contributor Author

btea commented Jun 6, 2025

@lukastaegert Thank you for your review. 👍

@lukastaegert lukastaegert added this pull request to the merge queue Jun 6, 2025
Merged via the queue into rollup:master with commit dddc00d Jun 6, 2025
41 checks passed
@btea btea deleted the feat/watch-add-allowInputInsideOutputPath branch June 6, 2025 14:38
Copy link

github-actions bot commented Jun 6, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to be able to have inputdir inside subpath of outputdir
3 participants