-
Notifications
You must be signed in to change notification settings - Fork 51
Fixes test to check epoch in package name #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
539f263 to
067b45a
Compare
|
/packit test rpm-software-management/dnf5#2447 |
1 similar comment
|
/packit test rpm-software-management/dnf5#2447 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't look at all the changes but the tests don't pass, not even with your PR.
It seems most of the changes are not needed.
I would maybe try to first run the main branch CI against a dnf5 build with your changes and then focus only on the failing tests.
| Problem: package filesystem-3.9-2.fc29.x86_64 from dnf-ci-fedora requires setup, but none of the providers can be installed | ||
| Problem: package filesystem-0:3.9-2.fc29.x86_64 from dnf-ci-fedora requires setup, but none of the providers can be installed | ||
| - conflicting requests | ||
| - package setup-2.12.1-1.fc29.noarch from dnf-ci-fedora is filtered out by exclude filtering | ||
| - package setup-0:2.12.1-1.fc29.noarch from dnf-ci-fedora is filtered out by exclude filtering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this message is from libsolv so its not affected by our change, it still doesn't add epoch 0.
| | filesystem-0:3.9-2.fc29.x86_64 | Dependency | dnf-ci-fedora | | ||
| | glibc-2.28-9.fc29.x86_64 | User | dnf-ci-fedora | | ||
| | glibc-all-langpacks-2.28-9.fc29.x86_64 | Dependency | dnf-ci-fedora | | ||
| | glibc-common-2.28-9.fc29.x86_64 | Dependency | dnf-ci-fedora | | ||
| | setup-2.12.1-1.fc29.noarch | Dependency | dnf-ci-fedora | | ||
| | setup-0:2.12.1-1.fc29.noarch | Dependency | dnf-ci-fedora | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't pass.
Its odd that the change would affect only a couple of all of the packages.
4e40fd7 to
6cee4fa
Compare
|
/packit test rpm-software-management/dnf5#2447 |
|
/packit test rpm-software-management/dnf5#2447 |
8f601e5 to
d07fd56
Compare
|
/packit test rpm-software-management/dnf5#2447 |
|
Thank you, I have tested it locally and the tests pass. |
Fixes test to check epoch in package name