Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fhbash
Copy link
Contributor

@fhbash fhbash commented Oct 7, 2025

Fixes test to check epoch in package name

@fhbash fhbash force-pushed the unify-epoch branch 3 times, most recently from 539f263 to 067b45a Compare October 14, 2025 12:49
@fhbash fhbash requested a review from kontura October 14, 2025 12:53
@fhbash
Copy link
Contributor Author

fhbash commented Oct 14, 2025

/packit test rpm-software-management/dnf5#2447

1 similar comment
@fhbash
Copy link
Contributor Author

fhbash commented Oct 16, 2025

/packit test rpm-software-management/dnf5#2447

@kontura kontura self-assigned this Oct 20, 2025
Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't look at all the changes but the tests don't pass, not even with your PR.
It seems most of the changes are not needed.

I would maybe try to first run the main branch CI against a dnf5 build with your changes and then focus only on the failing tests.

Comment on lines 129 to 131
Problem: package filesystem-3.9-2.fc29.x86_64 from dnf-ci-fedora requires setup, but none of the providers can be installed
Problem: package filesystem-0:3.9-2.fc29.x86_64 from dnf-ci-fedora requires setup, but none of the providers can be installed
- conflicting requests
- package setup-2.12.1-1.fc29.noarch from dnf-ci-fedora is filtered out by exclude filtering
- package setup-0:2.12.1-1.fc29.noarch from dnf-ci-fedora is filtered out by exclude filtering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this message is from libsolv so its not affected by our change, it still doesn't add epoch 0.

Comment on lines 55 to 59
| filesystem-0:3.9-2.fc29.x86_64 | Dependency | dnf-ci-fedora |
| glibc-2.28-9.fc29.x86_64 | User | dnf-ci-fedora |
| glibc-all-langpacks-2.28-9.fc29.x86_64 | Dependency | dnf-ci-fedora |
| glibc-common-2.28-9.fc29.x86_64 | Dependency | dnf-ci-fedora |
| setup-2.12.1-1.fc29.noarch | Dependency | dnf-ci-fedora |
| setup-0:2.12.1-1.fc29.noarch | Dependency | dnf-ci-fedora |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't pass.
Its odd that the change would affect only a couple of all of the packages.

@fhbash
Copy link
Contributor Author

fhbash commented Oct 23, 2025

/packit test rpm-software-management/dnf5#2447

@fhbash
Copy link
Contributor Author

fhbash commented Oct 29, 2025

/packit test rpm-software-management/dnf5#2447

@fhbash fhbash force-pushed the unify-epoch branch 2 times, most recently from 8f601e5 to d07fd56 Compare November 3, 2025 17:17
@fhbash
Copy link
Contributor Author

fhbash commented Nov 3, 2025

/packit test rpm-software-management/dnf5#2447

@fhbash fhbash requested a review from kontura November 3, 2025 21:22
@kontura
Copy link
Contributor

kontura commented Nov 4, 2025

Thank you, I have tested it locally and the tests pass.

@kontura kontura merged commit 371e56e into rpm-software-management:main Nov 4, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants