Fix rb_gc_impl_copy_finalizer
#13350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
casperisfine
commented
May 15, 2025
- Add missing VM_LOCK
- Generate a new object_id when copying finalizers
- Dup the finalizer entry so adding a finalizer on a cloned object doesn't impact the source object.
casperisfine
commented
May 15, 2025
| assert_in_out_err(["-e", <<-END], "", %w(:ok :ok :ok :ok), []) | ||
| assert_in_out_err(["-e", <<-END], "", %w(:ok :ok :ok), []) |
There was a problem hiding this comment.
My understanding is that this assertion was incorrect.
- We define 1 finalizer on the source object
- Clone the source object, so 1+1 => 2
- Add another finalizer on the copied object, so 2 + 1 => 3.
❌ Tests Failed✖️no tests failed ✔️61840 tests passed(1 flake) |
fdf9e04 to
60f41e2
Compare
Fix a regression introduced by: ruby#13155
60f41e2 to
63aaf67
Compare
gc/default/default.c
Outdated
| @@ -2832,16 +2835,22 @@ run_final(rb_objspace_t *objspace, VALUE zombie) | |||
| if (FL_TEST_RAW(zombie, FL_FINALIZE)) { | |||
| FL_UNSET(zombie, FL_FINALIZE); | |||
| st_data_t table; | |||
| unsigned int lev = rb_gc_vm_lock(); | |||
There was a problem hiding this comment.
I think we should do the locking in finalize_list instead. We lock the VM in finalize_list to add the slot back to the freelist, so we're just doing locking and unlocking twice for every zombie object instead of once total, which would be bad for performance.
There was a problem hiding this comment.
Good catch, I just had to move the lock up by one line.
The finalizer table can't be read nor modified without the VM lock.
ea38265 to
b0d2a3b
Compare
peterzhu2118
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.