refactor: Drop lazy_static dependency#515
Merged
epage merged 1 commit intorust-cli:mainfrom Oct 23, 2024
Merged
Conversation
matthiasbeyer
approved these changes
Feb 2, 2024
Contributor
Author
|
Sorry about that, examples should now be updated. |
Pull Request Test Coverage Report for Build 11478143095Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This was referenced Aug 15, 2025
epage
added a commit
that referenced
this pull request
Aug 20, 2025
The helper method is redundant (_introduced as a [bug fix in Mar 2022](#306), there is a much simpler approach to append the extension. - [`as_mut_os_string()`](https://doc.rust-lang.org/std/path/struct.Path.html#method.as_mut_os_str) has been available since Rust `1.70.0`, matching the MSRV of this crate since the introduction of [`OnceLock`](https://doc.rust-lang.org/std/sync/struct.OnceLock.html) [in Oct 2024](#515) (_`0.14.1` release_). - Additionally revised the comment and included a conditional statement to better communicate the intent for why this placeholder is necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #514