refactor: Remove add_dummy_extension() helper#682
Merged
epage merged 1 commit intorust-cli:mainfrom Aug 20, 2025
Merged
Conversation
This helper method is now redundant, there is a much simpler approach to append the extension with `as_mut_os_string()` (since Rust 1.70.0). Additionally revised the comment and included a conditional statement to better communicate the intent for why this placeholder is necessary.
Pull Request Test Coverage Report for Build 17087362576Details
💛 - Coveralls |
Contributor
Author
|
Lint failure is about commit message line length of 72. I personally consider that legacy, most interfaces for viewing commit messages should have the capability to line wrap 🤷♂️ That said, in the actual PR I did split the comment line to be under 120 characters in length. UX is harmed a tad when line length of the viewer is below that if line wrapping is enabled 😅 Let me know if you'd rather it be folded back into a single line (207 length). |
Contributor
As I said elsewhere and in the CI job message, the lint commit job is more of a suggestion than a hard requirement. |
add_dummy_extension() helperadd_dummy_extension() helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper method is redundant (introduced as a bug fix in Mar 2022), there is a much simpler approach to append the extension.
as_mut_os_string()has been available since Rust1.70.0, matching the MSRV of this crate since the introduction ofOnceLockin Oct 2024 (0.14.1release).