-
Notifications
You must be signed in to change notification settings - Fork 74
create issues for 2025h2 project goals #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add maximum iteration limit (10) to prevent infinite loops - Add validation to detect and report duplicate tracking issues - Provide clear error message when duplicate tracking issues are found Co-authored-by: Claude <[email protected]>
The span for the table needs to be the full span and we need to take a `Spanned<Table>`. I wonder what this will break that I'm not thinking of!
.arg("name,color") | ||
.arg("-L") | ||
.arg(format!("{limit}")) | ||
.output()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to check for the command's success as well, this will only check that the gh
process successfully spawned, but not that the command, and GH's server reply, was successful. There's an example just below, for the create
function.
This issue was sprinkled throughout the codebase, but I didn't have the time to fix it everywhere in 081512d
// Output in stdout looks like | ||
// | ||
// https://github.com/rust-lang/rust-project-goals/issues/413} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand, is this saying that it will print "https://github.com/rust-lang/rust-project-goals/issues/413}"?
| Metadata | | | ||
| :-- | :-- | | ||
| Point of contact | @PLeVasseur | | ||
| Status | Proposed | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all these be some form of "Accepted" or "Flagship"?
Apart from this, this looks good -- but my knowledge of Spanned and its manipulations is very limited. I'm also curious of the various ways in which the table rewriting could break in the future. Fun times ahead. |
And fix various random bugs I encountered in the script.
Rendered