Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Sep 17, 2025

And fix various random bugs I encountered in the script.

Rendered

nikomatsakis and others added 6 commits September 15, 2025 14:09
- Add maximum iteration limit (10) to prevent infinite loops
- Add validation to detect and report duplicate tracking issues
- Provide clear error message when duplicate tracking issues are found

Co-authored-by: Claude <[email protected]>
The span for the table needs to be the full span
and we need to take a `Spanned<Table>`.

I wonder what this will break that I'm not
thinking of!
@nikomatsakis nikomatsakis requested a review from lqd September 17, 2025 18:29
.arg("name,color")
.arg("-L")
.arg(format!("{limit}"))
.output()?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to check for the command's success as well, this will only check that the gh process successfully spawned, but not that the command, and GH's server reply, was successful. There's an example just below, for the create function.

This issue was sprinkled throughout the codebase, but I didn't have the time to fix it everywhere in 081512d

Comment on lines +203 to +205
// Output in stdout looks like
//
// https://github.com/rust-lang/rust-project-goals/issues/413}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand, is this saying that it will print "https://github.com/rust-lang/rust-project-goals/issues/413}"?

| Metadata | |
| :-- | :-- |
| Point of contact | @PLeVasseur |
| Status | Proposed |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all these be some form of "Accepted" or "Flagship"?

@lqd
Copy link
Member

lqd commented Sep 17, 2025

Apart from this, this looks good -- but my knowledge of Spanned and its manipulations is very limited. I'm also curious of the various ways in which the table rewriting could break in the future. Fun times ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants