☁️ Nx Cloud Report

CI is running/has finished running commands for commit 02506d1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

Sent with 💌 from NxCloud.

Trying my best to remove unrelated changes but the lint just keep adding "," back. I hope it is not too hard to review with those changes.

@maxisam
A rebase is needed. Then we can merge 🎉

@maxisam A rebase is needed. Then we can merge 🎉

Do you mean you prefer to rewrite some commits and force push it? I usually don't do that since I use squash merge in general.

However, if you prefer to keep some meaningful commits, I can rebase it and force push

we are generating the changelog from the commit messages. In best case they are meaningful and we don't have to squash. However, it's also possible. If we can fit your efforts into one meaningful commit message, it should also be fine. Wdyt @eneajaho ?

This PR was breaking, so I will merge this other one too (#1766) so we can release these new features in a minor instead of having to release a major version.

Basically the devs can configure the modify fn in two places and in the next major we can remove the one in the render config.