-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Uniquify requisite_in'd states checks. #68409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3006.x
Are you sure you want to change the base?
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey. There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR; please add tests.
9356b2d to
fa5de69
Compare
|
@bdrx312 Thanks for your review ! I added simplified code and unit tests. |
|
Thanks for the PR. Nice changes. |
Thanks :) It was buggy, but i now believe that the code is correct. Should I rebase/squash on 3006.x ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This needs a changelog.
- I'm super concerned that this could fix a bug and introduce others.
|
@dwoz changelog added. I tried my best with unit tests to avoid introducing bugs. Moreover, unit tests on |
|
Perhaps a functional or integration test, to provide a more thorough test. |
Fixes #68408
Introduce
_add_to_extendfor small factorization.The logic here is to prevent to append dependencies that are already in
extend[name][rstate][ind][rkey]: