Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@gpernot-celeste
Copy link

Fixes #68408

Introduce _add_to_extend for small factorization.

The logic here is to prevent to append dependencies that are already in extend[name][rstate][ind][rkey] :

for key in extend[name][rstate][ind][rkey]:
  if key.get(state) == id_:
    break

@gpernot-celeste gpernot-celeste requested a review from a team as a code owner October 17, 2025 19:10
@welcome
Copy link

welcome bot commented Oct 17, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here's some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We're glad you've joined our community and look forward to doing awesome things with you!

Copy link
Contributor

@bdrx312 bdrx312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; please add tests.

@gpernot-celeste
Copy link
Author

@bdrx312 Thanks for your review !

I added simplified code and unit tests.

@gpernot-celeste gpernot-celeste marked this pull request as draft October 20, 2025 01:26
@bdrx312
Copy link
Contributor

bdrx312 commented Oct 20, 2025

Thanks for the PR. Nice changes.

@gpernot-celeste
Copy link
Author

Thanks for the PR. Nice changes.

Thanks :)

It was buggy, but i now believe that the code is correct.

Should I rebase/squash on 3006.x ?

@gpernot-celeste gpernot-celeste marked this pull request as ready for review October 24, 2025 13:34
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This needs a changelog.
  • I'm super concerned that this could fix a bug and introduce others.

@gpernot-celeste
Copy link
Author

@dwoz changelog added.

I tried my best with unit tests to avoid introducing bugs.

Moreover, unit tests on check_requisite() should trigger regressions, if any.

@twangboy
Copy link
Contributor

Perhaps a functional or integration test, to provide a more thorough test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:full Run the full test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants