Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jerivas
Copy link
Contributor

@jerivas jerivas commented Jul 7, 2023

@jerivas jerivas requested a review from nex3 July 13, 2023 01:47
@ntkme
Copy link
Contributor

ntkme commented Jul 13, 2023

We also need to implement change in protofier.ts for conversion between proto type and JS type.

@jerivas
Copy link
Contributor Author

jerivas commented Jul 17, 2023

@nex3 @ntkme this is ready for another review

@jerivas jerivas requested a review from nex3 July 18, 2023 17:42
}
}

private deprotofyNumber(number: proto.Value_Number): SassNumber {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short doc comment for this.

@nex3 nex3 merged commit 786ab6c into sass:main Jul 19, 2023
@jerivas jerivas deleted the js-api-calculations branch July 20, 2023 16:47
@nex3 nex3 mentioned this pull request Dec 5, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants