-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add JS type definitions for calculations #3622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
nex3
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will hold off on merging until the implementation/test PRs are also in place 😅
jerivas
commented
Jul 7, 2023
jerivas
commented
Jul 7, 2023
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Aug 7, 2023
* main: Bump tj-actions/changed-files from 37.4.0 to 37.5.1 (sass#3643) [First-Class Mixins] Create a proposal (sass#3626) [Calc Functions] Fix the definition of rem() (sass#3641) Bump tj-actions/changed-files from 37.1.2 to 37.4.0 (sass#3640) [Color 4] Clarify in Known Color Spaces that lightness is clamped (sass#3639) Add JS type definitions for calculations (sass#3622) Bump tj-actions/changed-files from 37.1.0 to 37.1.2 (sass#3635) [Calculation API] Fix some issues brought up during implementation (sass#3631) Bump tj-actions/changed-files from 37.0.5 to 37.1.0 (sass#3632) [Calc Functions] Match the spec's behavior better for percentages (sass#3630) Bump tj-actions/changed-files from 37.0.2 to 37.0.5 (sass#3627) Fix a reference to a dead link (sass#3625)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #3605 and #3619
Related to
sass/dart-sass#1988
sass/sass-spec#1918