Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI: mergelies: drop JDK 23, add JDK 24 #11022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

CI: mergelies: drop JDK 23, add JDK 24 #11022

merged 2 commits into from
Apr 15, 2025

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 18, 2025 •
edited
Loading

JDK 24 is GA today

but I assume this won't immediately work. I'll come back every so often and retry.
UPDATE (Mar 24): yay, Temurin 24 is out and available through setup-java already

@SethTisue SethTisue self-assigned this Mar 18, 2025
@scala-jenkins scala-jenkins added this to the 2.12.21 milestone Mar 18, 2025
@SethTisue SethTisue added the internal not resulting in user-visible changes (build changes, tests, internal cleanups) label Mar 18, 2025
@SethTisue SethTisue mentioned this pull request Mar 18, 2025
Closed
9 tasks
@SethTisue SethTisue marked this pull request as ready for review March 24, 2025 23:07
@SethTisue SethTisue marked this pull request as draft March 24, 2025 23:08
@SethTisue
Copy link
Member Author

SethTisue commented Mar 24, 2025 •
edited
Loading

CI is failing with

[error] Error while emitting Command.scala
[error] Unsupported class file major version 68

I think that's because the reference compiler is still 2.12.20, which does not have the ASM 9.7.1 upgrade. so we need to re-STARR. I'll take care of it.

@SethTisue
Copy link
Member Author

SethTisue commented Mar 25, 2025 •
edited
Loading

2.12.21-M1:

@SethTisue SethTisue mentioned this pull request Mar 25, 2025
Closed
@SethTisue
Copy link
Member Author 

Error occurred during initialization of VM
java.lang.Error: A command line option has attempted to allow or enable the Security Manager. Enabling a Security Manager is not supported.
	at java.lang.System.initPhase3(java.base@24/System.java:1947)

@lrytz
Copy link
Member

lrytz commented Mar 31, 2025

https://github.com/scala/scala/blob/2.12.x/src/partest/scala/tools/partest/nest/TrapExit.scala probably?

@SethTisue
Copy link
Member Author

Yeah. I hadn't take a close look yet, not sure if we can just rip that out or whether something is relying on it.

@SethTisue SethTisue mentioned this pull request Apr 14, 2025
Merged
@SethTisue
Copy link
Member Author

SethTisue commented Apr 15, 2025 •
edited
Loading

@lrytz can have you a look at this inliner problem?

!!  211 - run/indyLambdaKinds                       [output differs]

@lrytz
Copy link
Member

lrytz commented Apr 15, 2025

!! 211 - run/indyLambdaKinds [output differs]

They changed the naming scheme for lambda implementation methods. I pushed an adjusted check file.

openjdk/jdk@8a4ea09#diff-2f93ccac06430fe73ffcaba8be8b0b2b811b6a87355d2ffdcbe9466cfe3a01abL1540

@lrytz
Copy link
Member

lrytz commented Apr 15, 2025

There seem to be a few more .exit calls in tests, maybe also 2.13 has more. If any of them cannot be removed, I guess the workaround is to add //> using javaOpt -Dneeds.forked.jvm, tests with java options run in a fresh jvm. I'll take a look.

lrytz
lrytz reviewed Apr 15, 2025
View reviewed changes
test/files/jvm/scala-concurrent-tck.scala
@@ -1018,7 +1018,3 @@ with Exceptions
with GlobalExecutionContext
with CustomExecutionContext
with ExecutionContextPrepare
{
System.exit(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on 2.13 there's a copy of this test that will need adjusting. couldn't spot any other on 2.13.

lrytz
lrytz reviewed Apr 15, 2025
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go after squashing (and removing the .github change)

@SethTisue SethTisue marked this pull request as ready for review April 15, 2025 20:19
@SethTisue SethTisue enabled auto-merge April 15, 2025 20:21
@SethTisue SethTisue merged commit 743891d into scala:2.12.x Apr 15, 2025
4 checks passed
@SethTisue SethTisue deleted the ci-gha-jdk24 branch April 16, 2025 01:40
@SethTisue
Copy link
Member Author

SethTisue commented Apr 16, 2025 •
edited
Loading

gah, I seem to have force-pushed d517e1c out of existence, even though I thought I was being careful 😕

I will submit it in a separate PR

@SethTisue SethTisue mentioned this pull request Apr 16, 2025
Merged
@SethTisue SethTisue mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz left review comments

Assignees

@SethTisue SethTisue

Labels
internal not resulting in user-visible changes (build changes, tests, internal cleanups)
Projects
None yet
Milestone
2.12.21
Development

Successfully merging this pull request may close these issues.
3 participants
@SethTisue @lrytz @scala-jenkins