Add flag to support source dependencies#394
Merged
Merged
Conversation
The main issue with source deps in Bloop arises from the fact that, by design, `bloopConfigDir` is build dependent, which means that it changes across different source deps. We don't want this to be the case for source dependencies though, since Bloop needs all the project dependencies to be in the same directory. For that reason, this flag aggregates the bloop config files to be written to the same bloop configuration directory, and hence have it work nicely with bloop. Fixes #375.
Duhemm
approved these changes
Mar 26, 2018
Collaborator
Duhemm
left a comment
There was a problem hiding this comment.
LGTM
We should maybe regen the config file and run the community build, just to be sure?
Contributor
Author
|
I double checked manually this does not affect the bloop files in our community build because this setting is always false. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main issue with source deps in Bloop arises from the fact that, by
design,
bloopConfigDiris build dependent, which means that it changesacross different source deps.
We don't want this to be the case for source dependencies though, since
Bloop needs all the project dependencies to be in the same directory.
For that reason, this flag aggregates the bloop config files to be
written to the same bloop configuration directory, and hence have it
work nicely with bloop.
Fixes #375.