Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove Imputer references in doc/modules/preprocessing.rst #10689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jnothman opened this issue Feb 24, 2018 · 9 comments · Fixed by #10750
Closed

Remove Imputer references in doc/modules/preprocessing.rst #10689

jnothman opened this issue Feb 24, 2018 · 9 comments · Fixed by #10750

Comments

@jnothman
Copy link
Member

We recently deprecated sklearn.preprocessing.Imputer and replaced it with sklearn.impute (#10483). But we forgot to remove references to the deprecated class from doc/modules/preprocessing.rst. Please remove them, and perhaps leave a note pointing to the new documentation at doc/modules/impute.rst.

@jnothman jnothman added Documentation good first issue Easy with clear instructions to resolve help wanted labels Feb 24, 2018
@whosford
Copy link

I'd like to work on this issue

@qinhanmin2014
Copy link
Member

@whosford @thechargedneutron has taken it (See #10483 (comment)).

@mohamed-ali
Copy link
Contributor

@jnothman, I guess this issue can be closed as @thechargedneutron took it in #10483 (comment) and his PR was merged. So, I assume the necessary work is already done.

@jnothman
Copy link
Member Author

jnothman commented Mar 4, 2018

They are certainly still there: http://scikit-learn.org/dev/modules/preprocessing.html#imputation-of-missing-values . I don't think @thechargedneutron has submitted a patch yet. I don't mind if someone else does and we finish this off, either

satishjasthi pushed a commit to satishjasthi/scikit-learn that referenced this issue Mar 7, 2018
Replace sklearn.preprocessing.Imputer with sklearn.impute
to fix issue
Remove Imputer references in doc/modules/preprocessing.rst scikit-learn#10689
@qinhanmin2014 qinhanmin2014 removed help wanted good first issue Easy with clear instructions to resolve labels Mar 7, 2018
@satishjasthi
Copy link
Contributor

@jnothman, I'm new to contributing to open source projects and I'm trying to resolve issue #10689, the issue is about replacing a depreciated function with the new function
But when I try to replace the depreciated issue with a new issue and create a PR, my commits are facing merge conflicts because of circle ci and lgtome tools

@jnothman
Copy link
Member Author

jnothman commented Mar 7, 2018

Firstly: There is already a PR for this issue, at #10750.

Secondly: the merge conflict is not because of Circle CI and lgtm.com, but because you have made your changes to a copy of the repository that does not include the most recent commits to master.

@satishjasthi
Copy link
Contributor

@jnothman Thank you for the response. I'm using git fetch upstream to update my master with respect to upstream branch, but still, I'm not able to see the upstream master changes in my branch, should I be using something else to sync with upstream master

@mohamed-ali
Copy link
Contributor

@satishjasthi , you need to

$git fetch upstream 
$git checkout master 
$git merge upstream/master 

After that your fork's master should be synced with the upstream master.

Then, you will need to rebase your branch with your fork's master.

@satishjasthi
Copy link
Contributor

@mohamed-ali Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants