-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Remove Imputer references in doc/modules/preprocessing.rst #10689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd like to work on this issue |
@whosford @thechargedneutron has taken it (See #10483 (comment)). |
@jnothman, I guess this issue can be closed as @thechargedneutron took it in #10483 (comment) and his PR was merged. So, I assume the necessary work is already done. |
They are certainly still there: http://scikit-learn.org/dev/modules/preprocessing.html#imputation-of-missing-values . I don't think @thechargedneutron has submitted a patch yet. I don't mind if someone else does and we finish this off, either |
Replace sklearn.preprocessing.Imputer with sklearn.impute to fix issue Remove Imputer references in doc/modules/preprocessing.rst scikit-learn#10689
@jnothman, I'm new to contributing to open source projects and I'm trying to resolve issue #10689, the issue is about replacing a depreciated function with the new function |
Firstly: There is already a PR for this issue, at #10750. Secondly: the merge conflict is not because of Circle CI and lgtm.com, but because you have made your changes to a copy of the repository that does not include the most recent commits to master. |
@jnothman Thank you for the response. I'm using git fetch upstream to update my master with respect to upstream branch, but still, I'm not able to see the upstream master changes in my branch, should I be using something else to sync with upstream master |
@satishjasthi , you need to
After that your fork's master should be synced with the upstream master. Then, you will need to rebase your branch with your fork's master. |
@mohamed-ali Thanks a lot |
We recently deprecated sklearn.preprocessing.Imputer and replaced it with sklearn.impute (#10483). But we forgot to remove references to the deprecated class from doc/modules/preprocessing.rst. Please remove them, and perhaps leave a note pointing to the new documentation at doc/modules/impute.rst.
The text was updated successfully, but these errors were encountered: