Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Crying emoticon in "Choosing the right estimator" does not work for most audiences #30283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clementinodemendonca opened this issue Nov 15, 2024 · 9 comments · Fixed by #30347

Comments

@clementinodemendonca
Copy link

Describe the issue linked to the documentation

Contrast https://github.com/scikit-learn/scikit-learn/blob/main/doc/images/ml_map.svg which uses a crying emoticon with previous versions where it said "Not Working" and were easier to understand.

I teach a brief class on Machine Learning Crying on a weekly basis and have always used "Choosing the right estimator" diagram to illustrate the typical high-level process that a data scientist goes through when picking the best algorithm for their problem, and how it leads to the need of automl and hyperparameter fine tuning. This has always worked well. However, more recently there has been a change where the words "Not working" were replaced by a "crying" emoticon. At first glance, no students in class understand what that means, even younger audiences. I have to magnify it, so they see what it actually is. And when I explain it, they find it awkward.

Suggest a potential alternative/fix

Possible solutions:

  1. Replace the crying emoticon back with text. It does not have to be "Not Working", it could be something else such as "needs improvement" or
  2. Replace the crying emoticon with the Hammer and Wrench emoji: https://emojiguide.org/hammer-and-wrench. Add a legend to the picture stating that it means "not working", "needs improvement", "more work needed". At least this emoji would be more emotionally neutral and would not be perceived as "awkward".
  3. At least add a legend explaining that the crying emoticon means "not working", "needs improvement", "more work needed".
@virchan
Copy link
Member

virchan commented Nov 17, 2024

I think the proposed solution is already implemented, as we've already explained the meaning of the crying emoji in the cheat sheet:

Screenshot 2024-11-17 224518

@glemaitre
Copy link
Member

Some I'm leaning towards closing this issue for the moment.

I think that there is another issue where it was discussed to update this map. When it happens, I would be willing to think of a better graphic cues.

@glemaitre glemaitre removed the Needs Triage Issue requires triage label Nov 18, 2024
@virchan
Copy link
Member

virchan commented Nov 18, 2024

@glemaitre, it might be #30076.

@clementinodemendonca
Copy link
Author

clementinodemendonca commented Nov 19, 2024 via email

@lesteve
Copy link
Member

lesteve commented Nov 26, 2024

It would be slightly nicer if the chart is kind of stand-alone, rather than needing legend explaining what the emoticon means ...

What about using "Try next" instead of the emoticon? I had a quick go at it on draw.io. I opened #30347. The advantage of "Try next" is that it is shorter than "Not working" and as things currently stands spacing is a bit limited to make the label fit inside the arrow.

image

See the svg version.

I am guessing that the emoticon 😭 was used to be compact but maybe @Charlie-XIAO or @adrinjalali remembers more? For this to fit, I had to move boxes around a bit.

Side-comment: orange "try next" arrow generally means here is another estimator you can try, but sometimes means a special case.:

  • "you have text data"
  • "you have more than 10k samples"

I guess the latter can be dealt with separately.

@lesteve
Copy link
Member

lesteve commented Nov 26, 2024

I think that there is another issue where it was discussed to update this map

@glemaitre, it might be #30076.

@virchan just FYI, I think @glemaitre has in mind a general update of the map (I don't think there is an issue for this yet, actually I found #7686 after a more thorough search), for example it does not mention some estimators we would recommend today like HistGradientBoostingRegressor/Classifier or LogisticRegression and some other estimators would likely be mentioned less or not at all (candidates are SVM, ElasticNet, probably more ...). This requires getting consensus and finding the right tradeoffs between information accuracy and keeping it simple for the user. As such, it is probably not going to happen overnight.

For some more background, users and teachers mostly love this map, maintainers generally think this is somewhat too simplistic, which is part of the reason it hasn't been updated much since it was created probably more than 10 years ago.

@Charlie-XIAO
Copy link
Contributor

Indeed - I used the emoji because "Not working" did not fit in. I agree that having explicit text is better (I think many people won't even notice there's a legend) - "TRY NEXT", or maybe "NOT WORK"? We could also make the text more compact by not using bold font and not capitalizing the letters, etc.

@clementinodemendonca
Copy link
Author

clementinodemendonca commented Nov 28, 2024 via email

@lesteve
Copy link
Member

lesteve commented Nov 29, 2024

Glad you like it, thanks for your feed-back @clementinodemendonca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants