-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Crying emoticon in "Choosing the right estimator" does not work for most audiences #30283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think the proposed solution is already implemented, as we've already explained the meaning of the crying emoji in the cheat sheet: ![]() |
Some I'm leaning towards closing this issue for the moment. I think that there is another issue where it was discussed to update this map. When it happens, I would be willing to think of a better graphic cues. |
@glemaitre, it might be #30076. |
I am OK with any solution, thank you for the attention. It looks like that the emoji has been explained in a future version to be released, and I like the explanation, though some of my students would prefer the symbol itself to be replaced by something more neutral.
One thing I personally see but did not mention is that since the crying emoji is partially yellow, it mixes with the background in the Classification section, but now that we will have the explanation it will be easier to understand.
Thank you!
…________________________________
From: Virgil Chan ***@***.***>
Sent: Monday, November 18, 2024 8:01 AM
To: scikit-learn/scikit-learn ***@***.***>
Cc: clementinodemendonca ***@***.***>; Author ***@***.***>
Subject: Re: [scikit-learn/scikit-learn] Crying emoticon in "Choosing the right estimator" does not work for most audiences (Issue #30283)
@glemaitre<https://github.com/glemaitre>, it might be #30076<#30076>.
—
Reply to this email directly, view it on GitHub<#30283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADEEAXJHFN5MX2C5NYUQIB32BHXKZAVCNFSM6AAAAABR3OKGEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBTGEZTGMZZGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
It would be slightly nicer if the chart is kind of stand-alone, rather than needing legend explaining what the emoticon means ... What about using "Try next" instead of the emoticon? I had a quick go at it on draw.io. I opened #30347. The advantage of "Try next" is that it is shorter than "Not working" and as things currently stands spacing is a bit limited to make the label fit inside the arrow. See the svg version. I am guessing that the emoticon 😭 was used to be compact but maybe @Charlie-XIAO or @adrinjalali remembers more? For this to fit, I had to move boxes around a bit. Side-comment: orange "try next" arrow generally means here is another estimator you can try, but sometimes means a special case.:
I guess the latter can be dealt with separately. |
@virchan just FYI, I think @glemaitre has in mind a general update of the map ( For some more background, users and teachers mostly love this map, maintainers generally think this is somewhat too simplistic, which is part of the reason it hasn't been updated much since it was created probably more than 10 years ago. |
Indeed - I used the emoji because "Not working" did not fit in. I agree that having explicit text is better (I think many people won't even notice there's a legend) - "TRY NEXT", or maybe "NOT WORK"? We could also make the text more compact by not using bold font and not capitalizing the letters, etc. |
Thank you so much to all those that worked on this issue. The solution is perfect. Happy Thanksgiving you all of you.
…________________________________
From: Yao Xiao ***@***.***>
Sent: Wednesday, November 27, 2024 12:50 AM
To: scikit-learn/scikit-learn ***@***.***>
Cc: clementinodemendonca ***@***.***>; Author ***@***.***>
Subject: Re: [scikit-learn/scikit-learn] Crying emoticon in "Choosing the right estimator" does not work for most audiences (Issue #30283)
Closed #30283<#30283> as completed via #30347<#30347>.
—
Reply to this email directly, view it on GitHub<#30283 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADEEAXL27XH7WBU3DRTQBLL2CVTRTAVCNFSM6AAAAABR3OKGEWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGQ2DONZXGIYTGMQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Glad you like it, thanks for your feed-back @clementinodemendonca! |
Describe the issue linked to the documentation
Contrast https://github.com/scikit-learn/scikit-learn/blob/main/doc/images/ml_map.svg which uses a crying emoticon with previous versions where it said "Not Working" and were easier to understand.
I teach a brief class on Machine Learning Crying on a weekly basis and have always used "Choosing the right estimator" diagram to illustrate the typical high-level process that a data scientist goes through when picking the best algorithm for their problem, and how it leads to the need of automl and hyperparameter fine tuning. This has always worked well. However, more recently there has been a change where the words "Not working" were replaced by a "crying" emoticon. At first glance, no students in class understand what that means, even younger audiences. I have to magnify it, so they see what it actually is. And when I explain it, they find it awkward.
Suggest a potential alternative/fix
Possible solutions:
The text was updated successfully, but these errors were encountered: