Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Use text label instead of emoticon in ML map #30347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Nov 26, 2024

Fix #30283.

Copy link

github-actions bot commented Nov 26, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 853a360. Link to the linter CI: here

@lesteve
Copy link
Member Author

lesteve commented Nov 26, 2024

See rendered doc

@Charlie-XIAO
Copy link
Contributor

Charlie-XIAO commented Nov 26, 2024

The rendering looks good, though you may need to update the links manually in the generated svg because draw.io seems to automatically resolve relative links. Quote ml_map.README.rst:

Each node in the chart that contains an estimator should have a link, where the root directory is at ../../. Note that after updating or re-exporting the SVG, the links may be prefixed with e.g. https://app.diagrams.net/. Remember to check and remove them, for instance by replacing all occurrences of https://app.diagrams.net/../../ with ../../.

Update: The above instructions seem outdated after we moved the map to under user guide. I think we should now be replacing https://app.diagrams.net/./ with ./.

@lesteve
Copy link
Member Author

lesteve commented Nov 26, 2024

Thanks, here is the new rendered doc with the fixed links. I check a few links they look good.

I also tweaked the README.

I have noticed there are some mentions in the svg of my repo I created to edit the image with draw.io (https://github.com/lesteve/drawio-playground) but I guess it's OK enough as long as the graphical rendering of the svg is fine 🤷:

If I search in the svg, I see for example:

resource="https://app.diagrams.net/#Hlesteve%2Fdrawio-playground%2Fmain%2Fml_map.svg#%7B%22pageId%22%3A%22prGmxGi5H6ogpCY3go2q%22%7D">

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise LGTM.


.. prompt:: bash

perl -pi -e 's@https://app.diagrams.net/\./@./@g' doc/images/ml_map.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perl still good for text. (I would have tried to do this with sed. 😅)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have enough space for one of this things in my brain feel free to suggest the equivalent in sed 😉

Copy link
Contributor

@Charlie-XIAO Charlie-XIAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Charlie-XIAO Charlie-XIAO merged commit 426e6be into scikit-learn:main Nov 27, 2024
30 checks passed
@lesteve lesteve deleted the ml-map-emoticon-tweak branch November 27, 2024 08:05
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Dec 4, 2024
jeremiedbb pushed a commit that referenced this pull request Dec 6, 2024
virchan pushed a commit to virchan/scikit-learn that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crying emoticon in "Choosing the right estimator" does not work for most audiences
3 participants