-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Use text label instead of emoticon in ML map #30347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Use text label instead of emoticon in ML map #30347
Conversation
See rendered doc |
The rendering looks good, though you may need to update the links manually in the generated svg because draw.io seems to automatically resolve relative links. Quote
Update: The above instructions seem outdated after we moved the map to under user guide. I think we should now be replacing |
Thanks, here is the new rendered doc with the fixed links. I check a few links they look good. I also tweaked the README. I have noticed there are some mentions in the svg of my repo I created to edit the image with draw.io (https://github.com/lesteve/drawio-playground) but I guess it's OK enough as long as the graphical rendering of the svg is fine 🤷: If I search in the svg, I see for example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, otherwise LGTM.
|
||
.. prompt:: bash | ||
|
||
perl -pi -e 's@https://app.diagrams.net/\./@./@g' doc/images/ml_map.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perl still good for text. (I would have tried to do this with sed. 😅)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have enough space for one of this things in my brain feel free to suggest the equivalent in sed
😉
Co-authored-by: Thomas J. Fan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Fix #30283.