Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Link to SAG paper dead, also should be mentionened in docstring #7512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Sep 28, 2016 · 3 comments
Closed

Link to SAG paper dead, also should be mentionened in docstring #7512

amueller opened this issue Sep 28, 2016 · 3 comments
Labels
Documentation Easy Well-defined and straightforward way to resolve

Comments

@amueller
Copy link
Member

The current link to the SAG paper in the LogisticRegression user guide is dead:
http://scikit-learn.org/dev/modules/linear_model.html#id23

Also, I think the methods should also (or maybe instead) be cited in the docstring of LogisticRegression, which currently only mentions the liblinear paper.
@amueller amueller added Easy Well-defined and straightforward way to resolve Documentation Need Contributor labels Sep 28, 2016
@iamprakashom
Copy link
Contributor

I am working on it.. 😄

@iamprakashom
Copy link
Contributor

@amueller, could you please have a look at https://hal.inria.fr/hal-00860051/document? This paper looks like the same paper whose link is dead. It seems that SAG paper has been moved to new location.

@amueller
Copy link
Member Author

@iamprakashom yeah that looks right.

iamprakashom added a commit to iamprakashom/scikit-learn that referenced this issue Sep 29, 2016
@iamprakashom
Link to SAG paper updated
2322c09 
link to SAG paper in `References` section updated (scikit-learn#7512).
iamprakashom added a commit to iamprakashom/scikit-learn that referenced this issue Sep 29, 2016
@iamprakashom
SAG paper cited in docstring
f5cb7bd 
SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
iamprakashom added a commit to iamprakashom/scikit-learn that referenced this issue Sep 29, 2016
@iamprakashom
Link to SAG paper updated
4cd8fe8 
dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512
@iamprakashom iamprakashom mentioned this issue Sep 29, 2016
Merged
iamprakashom added a commit to iamprakashom/scikit-learn that referenced this issue Sep 29, 2016
@iamprakashom
Link to SAG paper updated
26d6654 
dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512
iamprakashom added a commit to iamprakashom/scikit-learn that referenced this issue Sep 29, 2016
@iamprakashom
SAG paper cited in docstring
45a7f84 
SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
TomDLT pushed a commit that referenced this issue Sep 29, 2016
@iamprakashom @TomDLT
[MRG+1] minor link fix for SAG paper. (#7523)
32236ff 
* Link to SAG paper updated

link to SAG paper in `References` section updated (#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves #7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(#7512).
TomDLT pushed a commit to TomDLT/scikit-learn that referenced this issue Oct 3, 2016
@iamprakashom @TomDLT
[MRG+1] minor link fix for SAG paper. (scikit-learn#7523)
a230bb2 
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
amueller pushed a commit to amueller/scikit-learn that referenced this issue Oct 14, 2016
@iamprakashom @amueller
[MRG+1] minor link fix for SAG paper. (scikit-learn#7523)
7c7c05f 
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
@iamprakashom @Sundrique
[MRG+1] minor link fix for SAG paper. (scikit-learn#7523)
c5a048b 
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
@iamprakashom @paulha
[MRG+1] minor link fix for SAG paper. (scikit-learn#7523)
ab12e2c 
* Link to SAG paper updated

link to SAG paper in `References` section updated (scikit-learn#7512).

* Link to SAG paper updated

dead link of SAG paper in Logistic Regression user guide updated.
resolves scikit-learn#7512

* SAG paper cited in docstring

SAG paper cited in `Reference` section of docstring(scikit-learn#7512).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Easy Well-defined and straightforward way to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amueller @iamprakashom