-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
Search results on documentation website not appearing or overlapping with other web elements #7517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
thanks for the report, @rasbt . I did some digging and it seems like the issue was introduced in 331964e (I verified by building the docs @ the commit before, 7161755, verifying that the search looked proper, and then building the docs at the problematic commit to find what you're describing). I don't know enough about web technologies to tackle something like this. @Ajackster if you're still around would you happen to know how to fix it? Else maybe we should revert that commit...though hopefully a contributor would be able to help out. |
@nelson-liu thanks for looking into this! I wish I could help more, but I am also not that much into the web stuff and don't want to mess around with the docs since I don't fully understand how to build these. If it helps: I am using a similar Google "search bar" approach on my website, and it still seems to work there, so it's not that Google changed their API but sth must have happened to the sklearn docs like you mentioned. |
@nelson-liu Let us add a "need contributor" label here. |
Hey I can check this out tonight |
Thanks @Ajackster :) |
Nice one fixing this.. It needs to be propogated to 0.18 though as currently it's only on 0.19 dev version as far as I can tell. Else we're gonna have a broken search until the next release 😛 |
It's tagged 0.18.1 ;) |
…ikit-learn#7560) * Fixed search not expanding page * Changed the comment to warn users why not to leave fixed height on header
fixed in #7560. |
@rasbt The fix is queued up for the 0.18.1 release |
Oh I see, no worries then :). And thanks for the fix!!! |
…ikit-learn#7560) * Fixed search not expanding page * Changed the comment to warn users why not to leave fixed height on header
…ikit-learn#7560) * Fixed search not expanding page * Changed the comment to warn users why not to leave fixed height on header
Description
I noticed problems with the search results on the scikit-learn website. I am not sure if this problem just occurred today after 0.18 went live. Below is a screenshot of how it looks like when I do a search on the main page; on subpages the search does not seem to work altogether -- tested it on Chrome and Safari.
Steps/Code to Reproduce
Expected Results
Actual Results
Versions
The text was updated successfully, but these errors were encountered: