Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Search results on documentation website not appearing or overlapping with other web elements #7517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rasbt opened this issue Sep 28, 2016 · 11 comments
Milestone

Comments

@rasbt
Copy link
Contributor

rasbt commented Sep 28, 2016

Description

I noticed problems with the search results on the scikit-learn website. I am not sure if this problem just occurred today after 0.18 went live. Below is a screenshot of how it looks like when I do a search on the main page; on subpages the search does not seem to work altogether -- tested it on Chrome and Safari.

screen shot 2016-09-28 at 6 51 47 pm

Steps/Code to Reproduce

Expected Results

Actual Results

Versions

@nelson-liu
Copy link
Contributor

thanks for the report, @rasbt . I did some digging and it seems like the issue was introduced in 331964e (I verified by building the docs @ the commit before, 7161755, verifying that the search looked proper, and then building the docs at the problematic commit to find what you're describing).

I don't know enough about web technologies to tackle something like this. @Ajackster if you're still around would you happen to know how to fix it? Else maybe we should revert that commit...though hopefully a contributor would be able to help out.

@rasbt
Copy link
Contributor Author

rasbt commented Sep 29, 2016

@nelson-liu thanks for looking into this! I wish I could help more, but I am also not that much into the web stuff and don't want to mess around with the docs since I don't fully understand how to build these. If it helps: I am using a similar Google "search bar" approach on my website, and it still seems to work there, so it's not that Google changed their API but sth must have happened to the sklearn docs like you mentioned.

@sidgupta234
Copy link
Contributor

sidgupta234 commented Sep 29, 2016

@nelson-liu Let us add a "need contributor" label here.

@Ajackster
Copy link
Contributor

Hey I can check this out tonight

@amueller
Copy link
Member

Thanks @Ajackster :)

@jnothman jnothman added this to the 0.18.1 milestone Oct 4, 2016
jnothman pushed a commit that referenced this issue Oct 5, 2016
* Fixed search not expanding page

* Changed the comment to warn users why not to leave fixed height on header
@jaquesgrobler
Copy link
Member

Nice one fixing this.. It needs to be propogated to 0.18 though as currently it's only on 0.19 dev version as far as I can tell. Else we're gonna have a broken search until the next release 😛

@amueller
Copy link
Member

It's tagged 0.18.1 ;)

amueller pushed a commit to amueller/scikit-learn that referenced this issue Oct 14, 2016
…ikit-learn#7560)

* Fixed search not expanding page

* Changed the comment to warn users why not to leave fixed height on header
@amueller
Copy link
Member

fixed in #7560.

@rasbt
Copy link
Contributor Author

rasbt commented Oct 15, 2016

Has the patch been applied to the web version, yet? I just cleared my browser caches (Safari and Chrome) and still having this issue, but maybe it's just my machine(s)?

screen shot 2016-10-14 at 11 55 43 pm

@Ajackster
Copy link
Contributor

@rasbt The fix is queued up for the 0.18.1 release

@rasbt
Copy link
Contributor Author

rasbt commented Oct 15, 2016

Oh I see, no worries then :). And thanks for the fix!!!

Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
…ikit-learn#7560)

* Fixed search not expanding page

* Changed the comment to warn users why not to leave fixed height on header
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
…ikit-learn#7560)

* Fixed search not expanding page

* Changed the comment to warn users why not to leave fixed height on header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants