[MRG] DOC Fixed the display of search results (#7517) #7560
Conversation
|
Thanks for the PR @Ajackster ! I'll be sure to take a look at this once the circle build finishes. |
|
@nelson-liu Will this be a hot-fix or will this be released on next release? |
|
yeah we should totally backport this to 0.18 |
|
hmm, not sure why circle is failing here but I pushed these changes to my local fork and the search box seems to disappear. Here's the circleci build (https://circleci.com/gh/nelson-liu/scikit-learn/380) and the associated index.html (https://380-46840245-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/index.html) |
|
@nelson-liu that seems to be an issue with the google api (http) and circleci build (https). scikit-learn.org is just http so it should show up when it is merged into the live site. I don't know if there is a way to make the circleci build http. If you want to see/use the search bar on the circleci build, you will have to allow "unsafe" scripts to be used. |
|
@Ajackster oops I totally forgot that was a thing, that fixed it. I tested it out and it looks good to me. Search was never intended to be on the mobile interface, right? |
|
@nelson-liu not that I am aware of. It didn't seem to be implemented before/after 331964e . |
|
Ah ok, just making sure. |
|
If you download the full log you'll get this at the very end: I triggered a rebuild via the CircleCI interface. One way of doing it yourself is to do git commit --amend and force push. |
|
looks good to me now |
|
@lesteve thanks for fixing the circleci build! |
|
It would be nice if the input box and the search button had better alignment, but that's another issue. LGTM |
| @@ -42,7 +42,6 @@ ul.horizontal, ul.horizontal li { | |||
| div.header { | |||
| /* for the logo to correctly expand when showing results | |||
There was a problem hiding this comment.
@jnothman I can get rid of it but I think we should leave a warning message like
div.header { // DON'T ADD A FIXED HEIGHT }
so people don't make the same mistake I did.
There was a problem hiding this comment.
Why not but explain why rather than trying to scare people away with all-caps!
|
lgtm |
|
I can't say I like how the search results currently display, but this is much better than the broken state! (And I've attempted a hack at the search results so that they overlay but it wasn't as simple as I thought, given interaction with the navbar, the github banner, etc...) |
|
Thanks @Ajackster |
…ikit-learn#7560) * Fixed search not expanding page * Changed the comment to warn users why not to leave fixed height on header
…ikit-learn#7560) * Fixed search not expanding page * Changed the comment to warn users why not to leave fixed height on header
…ikit-learn#7560) * Fixed search not expanding page * Changed the comment to warn users why not to leave fixed height on header
Reference Issue
#7517
What does this implement/fix? Explain your changes.
Got rid of fixed height for header on desktop views so the search results would expand the page. Kept the fixed height on mobile views so the logo doesn't get squished.
Any other comments?