[MRG] DOC add missing attributes to LinearSVC, SVC and NuSVC #14424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `classes_` to attributes docstring
Copied exactly the same docstring from SVC
ingrid88
suggested changes
Aug 24, 2019
|
please resolve the merge conflict by fetching the upstream master and merging it into your branch |
186a118 to
842288d
Compare
|
@amueller conflict resolved :) |
Fix missing spaces fix missing spaces
|
Thanks for the pr @kevinwinatamichael, this one looks just about done, could you finish up the last bit with the missing space so we could get it merged please? Looks like that test didn't pass. Thanks! |
|
Hi @kellycarmody Ingrid: would you be able to finish up on the work you started at the #wimlds sprint? |
|
I notice that now some of the attributes is duplicated because of some merging from other PR (#14459). And by now there's too much merge commit in the branch. I think it would be cleaner if I just make a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Partially addresses #14312
What does this implement/fix? Explain your changes.
Added
classes_attributes docstring to LinearSVC,Added
class_weight_, classes_, fit_status_, probA_, probB_, shape_fit_attributes docstring to NuSVC,Added
class_weight_, classes_, shape_fit_attributes docstring to SVC.Any other comments?